Project

General

Profile

Actions

Bug #2812

closed

We are catching Throwable !

Added by François ARMAND over 12 years ago. Updated about 12 years ago.

Status:
Released
Priority:
2
Category:
Architecture - Code maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

In several class in Rudder, we are catching Throwable ! We DO NOT have to catch that !

For example, we are catching OutOfMemory errors !

Change Throwable by Exception.

Liste of know cases:

- rudder/rudder-core/src/main/scala/com/normation/rudder/batch/AsyncDeploymentAgent.scala
- rudder/rudder-core/src/main/scala/com/normation/rudder/batch/UpdateDynamicGroups.scala
- rudder/rudder-core/src/main/scala/com/normation/rudder/repository/jdbc/EventLogJdbcRepository.scala

Actions #1

Updated by Jonathan CLARKE over 12 years ago

  • Target version changed from 2.4.0~beta4 to 2.4.0~beta5
Actions #2

Updated by François ARMAND over 12 years ago

  • Status changed from 2 to Pending technical review
  • % Done changed from 0 to 100
Actions #3

Updated by Nicolas CHARLES about 12 years ago

  • Status changed from Pending technical review to Released

This looks valid, thank you Francois

Actions

Also available in: Atom PDF