Bug #2851
closedViewing Directive modification diff in the event logs is too ugly
Description
Currently the dozens of crossed out lines are really ugly, and hard to read. We MUST change this before 2.4 is released.
Files
Updated by Jean VILVER over 12 years ago
- Status changed from 2 to Pending technical review
#2782 provides a good result for this problem. I'm putting this ticket in technical review.
Updated by Jean VILVER over 12 years ago
- File diff_option_with_no_background.png diff_option_with_no_background.png added
- File diff_option_by_default.png diff_option_by_default.png added
- File diff_only_background_differences.png diff_only_background_differences.png added
- Status changed from Pending technical review to Discussion
- Assignee changed from Jean VILVER to Jonathan CLARKE
- Target version changed from 2.4.0~beta5 to 2.4.0~rc1
I have 3 other solutions, see screenshots attached. What do you think Jon ?
Updated by Nicolas CHARLES over 12 years ago
I prefer diff_only_background_differences.png most !But I'm not Jon :)
Updated by Jonathan CLARKE over 12 years ago
- Assignee changed from Jonathan CLARKE to Jean VILVER
Thanks for looking into this Jean.
Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.
Updated by Nicolas CHARLES over 12 years ago
Jonathan CLARKE wrote:
Thanks for looking into this Jean.
Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.
Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)
Updated by Jonathan CLARKE over 12 years ago
Nicolas CHARLES wrote:
Jonathan CLARKE wrote:
Thanks for looking into this Jean.
Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.
Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?
Updated by Jean VILVER over 12 years ago
Jonathan CLARKE wrote:
[...]
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?
The result is in the attached image. But it doesn't feel green without the green text of diff_option_by_default.
Updated by Jean VILVER over 12 years ago
Another one, but with lighter colors.
Updated by Jonathan CLARKE over 12 years ago
Jean VILVER wrote:
Jonathan CLARKE wrote:
[...]
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?The result is in the attached image. But it doesn't feel green without the green text of diff_option_by_default.
Perfect. Thanks Jean!
Updated by Jean VILVER over 12 years ago
- Status changed from Discussion to Pending technical review
The commit is in #2782.
Updated by François ARMAND over 12 years ago
- Status changed from Pending technical review to Released
I closed that one, the relevant description is in #2782.
Updated by Nicolas PERRON over 12 years ago
- Target version changed from 2.4.0~rc1 to 2.4.0~beta5