Project

General

Profile

Actions
Copy link

Bug #2851

closed

Viewing Directive modification diff in the event logs is too ugly

Added by Jonathan CLARKE over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
2
Assignee:
Jean VILVER
Category:
Web - Maintenance
Target version:
2.4.0~beta5
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Currently the dozens of crossed out lines are really ugly, and hard to read. We MUST change this before 2.4 is released.

Files

Download all files
diff_option_with_no_background.png (73.7 KB) diff_option_with_no_background.png Jean VILVER, 2012-09-04 12:00
diff_option_by_default.png (75.3 KB) diff_option_by_default.png Jean VILVER, 2012-09-04 12:00
diff_only_background_differences.png (75 KB) diff_only_background_differences.png Jean VILVER, 2012-09-04 12:00
diff_default_with_black_text.png (75.1 KB) diff_default_with_black_text.png Jean VILVER, 2012-09-04 14:29
diff_only_background_lighter.png (74.6 KB) diff_only_background_lighter.png Jean VILVER, 2012-09-04 14:38

Related issues 1 (0 open — 1 closed)

Is duplicate of Rudder - User story #2782: Use a real diff viewing for Directive modification event logReleasedJean VILVER2012-08-08Actions
Actions
Copy link
 #1

Updated by Jean VILVER over 11 years ago

  • Status changed from 2 to Pending technical review

#2782 provides a good result for this problem. I'm putting this ticket in technical review.

Actions
Copy link Download all files
 #2

Updated by Jean VILVER over 11 years ago

I have 3 other solutions, see screenshots attached. What do you think Jon ?

Actions
Copy link
 #3

Updated by Nicolas CHARLES over 11 years ago

I prefer diff_only_background_differences.png most !But I'm not Jon :)

Actions
Copy link
 #4

Updated by Jonathan CLARKE over 11 years ago

  • Assignee changed from Jonathan CLARKE to Jean VILVER

Thanks for looking into this Jean.

Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.

Actions
Copy link
 #5

Updated by Nicolas CHARLES over 11 years ago

Jonathan CLARKE wrote:

Thanks for looking into this Jean.

Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.

Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)

Actions
Copy link
 #6

Updated by Jonathan CLARKE over 11 years ago

Nicolas CHARLES wrote:

Jonathan CLARKE wrote:

Thanks for looking into this Jean.

Without hesitation, I prefer diff_option_by_default.png. The background colour makes it very clear what lines we need to be looking at. The "+/-" at the beginning of the line are important for the convention to tell readers "this is a diff". The coloured text helps make it easier on the eyes, in my opinion.

Caution, Red on Red and Green on Green are very poor in term of readability (I have difficulty to read the green on green line)

OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?

Actions
Copy link
 #7

Updated by Jean VILVER over 11 years ago

Jonathan CLARKE wrote:

[...]
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?

The result is in the attached image. But it doesn't feel green without the green text of diff_option_by_default.

Actions
Copy link
 #8

Updated by Nicolas CHARLES over 11 years ago

that's ok for me, thank you

Actions
Copy link
 #9

Updated by Jean VILVER over 11 years ago

Another one, but with lighter colors.

Actions
Copy link
 #10

Updated by Jonathan CLARKE over 11 years ago

Jean VILVER wrote:

Jonathan CLARKE wrote:

[...]
OK, I see what you mean. How about we keep the black text, but use the softer background colours from diff_option_by_default?

The result is in the attached image. But it doesn't feel green without the green text of diff_option_by_default.

Perfect. Thanks Jean!

Actions
Copy link
 #11

Updated by Jean VILVER over 11 years ago

  • Status changed from Discussion to Pending technical review

The commit is in #2782.

Actions
Copy link
 #12

Updated by François ARMAND over 11 years ago

  • Status changed from Pending technical review to Released

I closed that one, the relevant description is in #2782.

Actions
Copy link
 #13

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 2.4.0~rc1 to 2.4.0~beta5
Actions
Copy link

Also available in: Atom PDF