Rudder

I've work on this ticket, and I have two options to solve it.

If you want to try other options just tell me, I'll add more.

(Note that the solution we'll be use on every tables.)

Option 1 :

Option 2 :

Jean VILVER wrote:

I've work on this ticket, and I have two options to solve it.

If you want to try other options just tell me, I'll add more.

(Note that the solution we'll be use on every tables.)

Option 1 :

Option 1 is OK for me, so long as there are tooltips above the arrows (<<, <, > and >>) that say "First", "Previous", "Next" and "Last". If this is not possible, we must stick with option 2, but I'm sure you can add some tooltips :)

Jean VILVER wrote:

I've tried to find an example with this behavior but I couldn't.

Still, I tried to implement it but, it's not an easy task. I think that I have to alter the dataTable plugin to generate a different html code, in order to use the tooltips that we use in other parts of rudder.

So, I guess we should go with option 2, but maybe with a better presentation : the table on the home page of http://datatables.net/.

Should I go with option 2 or with a better option 2 ?

Agreed. If you can do "better option 2" quickly and easily, then go for it :)

The result :

before:

after:

In event_logs_improve_after.png, we can see a border-left on every cell of the table, I'm removing this border.

Plus, the width of the columns change when we click on the table headers in order to sort the table's lines. This behavior can be annoying. It's much better to have a fixed column width while sorting.

Applied in changeset 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce.

Changes in 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce:
- The border-left on every cell is removed
- While sorting lines, the column width is not affected (except when the table has a small width, which happens when the window width is small)

The result:

This looks valid, thank you Jean.
The sDom option of datatables looks very convenient

I'm reverting my technical review agreement.
Jean, one should never change the content of ui-lightness, lest we can't upgrade to newer version of jquery/jquery-ui without breaking stuffs
Could you please do all the necessary modification to reverts or amends commit 038b1dffb6f74936456d0f32dd68c698c3269e03, fc330192a7aba5bb039fbff5472d9046e8a679ec, ccfb0cd9e8227d09a4b7f4d3eddb8a1b0ea856a1, 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce (which are linked to ticket #2669, and this ticket) so that the ui-lightness theme is restored to its initial state, and move the modification to the jquery-rudder-bridge.css ?

Nicolas CHARLES wrote:

[...]
Could you please do all the necessary modification to reverts or amends commit 038b1dffb6f74936456d0f32dd68c698c3269e03, fc330192a7aba5bb039fbff5472d9046e8a679ec, ccfb0cd9e8227d09a4b7f4d3eddb8a1b0ea856a1, 2fe522ee53c9ba8e62d242547a7feb93fe6bbdce (which are linked to ticket #2669, and this ticket) so that the ui-lightness theme is restored to its initial state, and move the modification to the jquery-rudder-bridge.css ?

Done in 79b123b231bcc4752cc62110a627fc4477bfb6b0.

Thank you Jean, this seems valid