Project

General

Profile

Actions
Copy link

User story #2887

closed

Add a warning in the checkGenericFileContent Technique about quotes

Added by Matthieu CERDA over 12 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
3
Assignee:
Matthieu CERDA
Category:
Techniques
Target version:
2.3.10
Pull Request:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

In the Content of the file (optional): part of the Technique, a warning about the need to escape quotes should be added.

Related issues 2 (0 open — 2 closed)

Related to Rudder - Architecture #2432: Warn user if he inputs a "risky" value in a directiveBacklogActions
Related to Rudder - User story #1848: Escape special characters like ' " or ! in directive valuesRejected2011-09-26Actions
Actions
Copy link
 #1

Updated by Nicolas PERRON about 12 years ago

  • Target version changed from 2.4.0~rc1 to 2.4.0~rc2

This ticket have to be postponed to 2.4.0~rc2

Actions
Copy link
 #2

Updated by Nicolas PERRON about 12 years ago

  • Target version changed from 2.4.0~rc2 to 2.4.0
Actions
Copy link
 #3

Updated by Matthieu CERDA about 12 years ago

  • Status changed from New to 13
  • Assignee set to Matthieu CERDA
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Jonathan CLARKE about 12 years ago

  • Status changed from 13 to Discussion
  • Target version changed from 2.4.0 to 2.3.10

Thanks for this Matthieu. Your pull request looks fine, but I don't understand why it's only on the 2.4 branch - it should also be on 2.3, surely?

Also, is this feature not related to a discussion we had in another ticket? If so, please add a reference to that ticket here, and of this ticket there, so we can keep track of what was done.

Actions
Copy link
 #5

Updated by Matthieu CERDA almost 12 years ago

I found a lone ticket that is linked to this: #2432

Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?

Actions
Copy link
 #6

Updated by Matthieu CERDA almost 12 years ago

  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
Actions
Copy link
 #7

Updated by Jonathan CLARKE almost 12 years ago

  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

Matthieu CERDA wrote:

I found a lone ticket that is linked to this: #2432

I think #1848 is closer, actually.

Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?

Yep.

Actions
Copy link
 #8

Updated by Matthieu CERDA almost 12 years ago

  • Status changed from Discussion to 10

The correction has been applied to both Rudder 2.3 and 2.4.

Actions
Copy link
 #9

Updated by Jonathan CLARKE almost 12 years ago

  • Status changed from 10 to Pending release
Actions
Copy link
 #10

Updated by Nicolas PERRON almost 12 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #11

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF