User story #2887
closed
Add a warning in the checkGenericFileContent Technique about quotes
Added by Matthieu CERDA about 12 years ago.
Updated over 9 years ago.
Description
In the Content of the file (optional): part of the Technique, a warning about the need to escape quotes should be added.
- Target version changed from 2.4.0~rc1 to 2.4.0~rc2
This ticket have to be postponed to 2.4.0~rc2
- Target version changed from 2.4.0~rc2 to 2.4.0
- Status changed from New to 13
- Assignee set to Matthieu CERDA
- % Done changed from 0 to 100
- Status changed from 13 to Discussion
- Target version changed from 2.4.0 to 2.3.10
Thanks for this Matthieu. Your pull request looks fine, but I don't understand why it's only on the 2.4 branch - it should also be on 2.3, surely?
Also, is this feature not related to a discussion we had in another ticket? If so, please add a reference to that ticket here, and of this ticket there, so we can keep track of what was done.
I found a lone ticket that is linked to this: #2432
Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?
- Assignee changed from Matthieu CERDA to Jonathan CLARKE
- Assignee changed from Jonathan CLARKE to Matthieu CERDA
Matthieu CERDA wrote:
I found a lone ticket that is linked to this: #2432
I think #1848 is closer, actually.
Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?
Yep.
- Status changed from Discussion to 10
The correction has been applied to both Rudder 2.3 and 2.4.
- Status changed from 10 to Pending release
- Status changed from Pending release to Released
- Project changed from 24 to Rudder
- Category changed from Techniques to Techniques
Also available in: Atom
PDF
Updated by Nicolas PERRON 
Updated by Matthieu CERDA 
Updated by Jonathan CLARKE 
Updated by