User story #2887: Add a warning in the checkGenericFileContent Technique about quotes - Rudder - Issue Tracker

Custom queries

Bugs triage
CS - by assignee
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

User story #2887

closed

Add a warning in the checkGenericFileContent Technique about quotes

User story #2887: Add a warning in the checkGenericFileContent Technique about quotes

Added by Matthieu CERDA about 13 years ago. Updated over 10 years ago.

Status:

Released

Priority:

Assignee:

Matthieu CERDA

Category:

Techniques

Target version:

2.3.10

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

In the Content of the file (optional): part of the Technique, a warning about the need to escape quotes should be added.

Related issues 2 (0 open — 2 closed)

	Related to Rudder - Architecture #2432: Warn user if he inputs a "risky" value in a directive	Backlog		Actions
	Related to Rudder - User story #1848: Escape special characters like ' " or ! in directive values	Rejected		Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#1

Target version changed from 2.4.0~rc1 to 2.4.0~rc2

This ticket have to be postponed to 2.4.0~rc2

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#2

Target version changed from 2.4.0~rc2 to 2.4.0

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#3

Status changed from New to 13
Assignee set to Matthieu CERDA
% Done changed from 0 to 100

Done, Review pending here: https://github.com/Normation/rudder-techniques/pull/12

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#4

Status changed from 13 to Discussion
Target version changed from 2.4.0 to 2.3.10

Thanks for this Matthieu. Your pull request looks fine, but I don't understand why it's only on the 2.4 branch - it should also be on 2.3, surely?

Also, is this feature not related to a discussion we had in another ticket? If so, please add a reference to that ticket here, and of this ticket there, so we can keep track of what was done.

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#5

I found a lone ticket that is linked to this: #2432

Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#6

Assignee changed from Matthieu CERDA to Jonathan CLARKE

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#7

Assignee changed from Jonathan CLARKE to Matthieu CERDA

Matthieu CERDA wrote:

I found a lone ticket that is linked to this: #2432

I think #1848 is closer, actually.

Actually, there is no reason for this ticket to be 2.4 only. Should we delete the pull request and apply the change to the 2.3 ?

Yep.

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#8

Status changed from Discussion to 10

The correction has been applied to both Rudder 2.3 and 2.4.

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#9

Status changed from 10 to Pending release

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
#10

Status changed from Pending release to Released

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
#11

Project changed from 24 to Rudder
Category changed from Techniques to Techniques

Actions

Copy link

Also available in: PDF Atom

Project

General

Profile

Rudder

Custom queries

User story #2887

Add a warning in the checkGenericFileContent Technique about quotes

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#1

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#2

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#3

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#4

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#5

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#6

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#7

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#8

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#9

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
#10

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
#11

Project

General

Profile

Rudder

Custom queries

User story #2887

Add a warning in the checkGenericFileContent Technique about quotes

Updated by Nicolas PERRON almost 13 years ago ActionsCopy link #1

Updated by Nicolas PERRON almost 13 years ago ActionsCopy link #2

Updated by Matthieu CERDA almost 13 years ago ActionsCopy link #3

Updated by Jonathan CLARKE almost 13 years ago ActionsCopy link #4

Updated by Matthieu CERDA almost 13 years ago ActionsCopy link #5

Updated by Matthieu CERDA almost 13 years ago ActionsCopy link #6

Updated by Jonathan CLARKE almost 13 years ago ActionsCopy link #7

Updated by Matthieu CERDA almost 13 years ago ActionsCopy link #8

Updated by Jonathan CLARKE almost 13 years ago ActionsCopy link #9

Updated by Nicolas PERRON over 12 years ago ActionsCopy link #10

Updated by Benoît PECCATTE over 10 years ago ActionsCopy link #11

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#1

Updated by Nicolas PERRON almost 13 years ago Actions
Copy link
#2

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#3

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#4

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#5

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#6

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#7

Updated by Matthieu CERDA almost 13 years ago Actions
Copy link
#8

Updated by Jonathan CLARKE almost 13 years ago Actions
Copy link
#9

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
#10

Updated by Benoît PECCATTE over 10 years ago Actions
Copy link
#11