Rudder

The fix is simple: use body class if_else instead of cf2_if_else.

The reason is that we are expecting a success report for an action (copy some files) but if the action is not necessary, the class is not thrown as the body class cf2_if_else doesn't implement kept:

body classes cf2_if_else(yes,no)
# meant to match cf2 semantics
{
promise_repaired => { "$(yes)" };
repair_failed    => { "$(no)" };
repair_denied    => { "$(no)" };
repair_timeout   => { "$(no)" };
}

body classes if_else(yes,no)
{
promise_kept     => { "$(yes)" };
promise_repaired => { "$(yes)" };
repair_failed    => { "$(no)" };
repair_denied    => { "$(no)" };
repair_timeout   => { "$(no)" };
}

The commit is commit:99fb64fda13fc9d60cef217293cf967ef567f886

This has been changed in the Techniques, but not in the initial promises. Is there a reason for this? Shouldn't it be sync'd?

Jonathan CLARKE wrote:

This has been changed in the Techniques, but not in the initial promises. Is there a reason for this? Shouldn't it be sync'd?

That's a good question.
The first thing the server does is to generate its own promises, so I guess it doesn't have much impact
But for better consistency it should be sync'd

Nicolas CHARLES wrote:

The pull lrequest for the initial promises is here :
https://github.com/Normation/rudder-techniques/pull/22
Could you review it Jon ?

Great, merged. Thanks.