Project

General

Profile

Actions

Bug #3162

closed

Diff in modify directive event log is not correct

Added by Vincent MEMBRÉ almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
4
Category:
Web - Maintenance
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The actual diff in modify directive is not correct

There are some (plus/minus)ses missing and there is a blankspace that should not be here (in unchanged firt line)

it looks like :

 <section name="sections">
  <section name="File to manage">
    <section name="File">
+     <var name="GENERIC_FILE_CONTENT_CREATE_BOOLEAN">false</var>
+     <var name="GENERIC_FILE_CONTENT_DELETION_BOOLEAN">false</var>
       <var name="GENERIC_FILE_CONTENT_ENFORCE">false</var>
+     <var name="GENERIC_FILE_CONTENT_MODIFICATION_BOOLEAN">false</var>
+     <var name="GENERIC_FILE_CONTENT_PATH">/tmp/test</var>
    </section>
    <section name="File content">
      <var name="GENERIC_FILE_CONTENT_PAYLOAD">f**cking content</var>
    </section>
    <section name="Line deletion regular expressions">
      <var name="GENERIC_FILE_CONTENT_DELETION_REGEXP">.</var>
    </section>
    <section name="Line replacement regular expressions">
      <var name="GENERIC_FILE_CONTENT_MODIFICATION_DESTINATION"></var>
      <var name="GENERIC_FILE_CONTENT_MODIFICATION_REGEXP">.</var>
    </section>
    <section name="Permission adjustment">
       <var name="GENERIC_FILE_CONTENT_GROUP">root</var>
      <var name="GENERIC_FILE_CONTENT_OWNER">root</var>
-     <var name="GENERIC_FILE_CONTENT_PATH">/tmp/test</var>
-     <var name="GENERIC_FILE_CONTENT_PAYLOAD">f**cking content</var>
       <var name="GENERIC_FILE_CONTENT_PERM">644</var>
+     <var name="GENERIC_FILE_CONTENT_PERMISSION_ADJUSTMENT">false</var>
     </section>
    <section name="Post-modification hook">
      <var name="GENERIC_FILE_CONTENT_POST_HOOK_COMMAND"></var>
      <var name="GENERIC_FILE_CONTENT_POST_HOOK_RUN">false</var>
    </section>
  </section>
</section>

and should look like :

<section name="sections">
  <section name="File to manage">
    <section name="File">
+     <var name="GENERIC_FILE_CONTENT_CREATE_BOOLEAN">false</var>
+     <var name="GENERIC_FILE_CONTENT_DELETION_BOOLEAN">false</var>
       <var name="GENERIC_FILE_CONTENT_ENFORCE">false</var>
+     <var name="GENERIC_FILE_CONTENT_MODIFICATION_BOOLEAN">false</var>
+     <var name="GENERIC_FILE_CONTENT_PATH">/tmp/test</var>
+   </section>
+   <section name="File content">
+     <var name="GENERIC_FILE_CONTENT_PAYLOAD">f**cking content</var>
+   </section>
+   <section name="Line deletion regular expressions">
+     <var name="GENERIC_FILE_CONTENT_DELETION_REGEXP">.</var>
+   </section>
+   <section name="Line replacement regular expressions">
+     <var name="GENERIC_FILE_CONTENT_MODIFICATION_DESTINATION"></var>
+     <var name="GENERIC_FILE_CONTENT_MODIFICATION_REGEXP">.</var>
+   </section>
+   <section name="Permission adjustment">
      <var name="GENERIC_FILE_CONTENT_GROUP">root</var>
      <var name="GENERIC_FILE_CONTENT_OWNER">root</var>
-     <var name="GENERIC_FILE_CONTENT_PATH">/tmp/test</var>
-     <var name="GENERIC_FILE_CONTENT_PAYLOAD">f**cking content</var>
      <var name="GENERIC_FILE_CONTENT_PERM">644</var>
+     <var name="GENERIC_FILE_CONTENT_PERMISSION_ADJUSTMENT">false</var>
    </section>
    <section name="Post-modification hook">
      <var name="GENERIC_FILE_CONTENT_POST_HOOK_COMMAND"></var>
      <var name="GENERIC_FILE_CONTENT_POST_HOOK_RUN">false</var>
    </section>
  </section>
</section>
Actions #1

Updated by Vincent MEMBRÉ almost 12 years ago

  • Category set to Web - Maintenance
  • Assignee set to Vincent MEMBRÉ
  • Priority changed from N/A to 4
  • Target version set to 2.4.3
Actions #2

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from New to In progress
Actions #3

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from In progress to Pending technical review
Actions #4

Updated by Vincent MEMBRÉ almost 12 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions #5

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #6

Updated by Anonymous almost 12 years ago

Actions #9

Updated by Nicolas PERRON almost 12 years ago

  • Status changed from Pending release to Released
Actions

Also available in: Atom PDF