Project

General

Profile

Actions
Copy link

Bug #3181

closed

Deleted node is still marked as accepted in "Accept new nodes/History" panel

Added by Jean Remond almost 12 years ago. Updated almost 12 years ago.

Status:
Released
Priority:
3
Assignee:
François ARMAND
Category:
Web - Nodes & inventories
Target version:
2.4.3
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

To reproduce the bug, add a node then delete it and look in "History" panel

Files

deletedNode_History_Grid (27.1 KB) deletedNode_History_Grid Vincent MEMBRÉ, 2013-01-15 18:20
Actions
Copy link
 #1

Updated by Jonathan CLARKE almost 12 years ago

  • Category set to Web - Nodes & inventories
  • Status changed from New to 8
  • Priority changed from N/A to 3
  • Target version changed from 2.5.0~rc1 to 2.4.3

I see what you mean. This "History" view is supposed to show a log of what nodes were accepted or refused, so I don't think that a node should be removed from the history after being deleted (this would effectifly delete an audit trail).

However, it would make sense to add a message here to say "This node was deleted from Rudder on 01/02/2012 at 12:23 by jon.doe".

Actions
Copy link
 #2

Updated by Jean Remond almost 12 years ago

Yes adding a message with "State : deleted" is good for me

Actions
Copy link
 #3

Updated by François ARMAND almost 12 years ago

  • Assignee set to Vincent MEMBRÉ
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ almost 12 years ago

Would it be better if the node history grid displays a line for every delete node event ?

Displaying a line with the same information than the others (hostname, etc ...) and marked as Deleted

Clicking on it will displays the inventory ? (like refuse and accept ?)

I added a picture of what I mean!

Actions
Copy link
 #5

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from 8 to Discussion
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

Jon, what do you think about that idea ?

Actions
Copy link
 #6

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from Discussion to In progress

Discussed it with Jon, The deleted event should not be displayed in that table.

But clicking on a deleted node should display a warning displaying us that the node was deleted, with its deletion date, and who did it.

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 12 years ago

  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
Actions
Copy link
 #8

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #9

Updated by François ARMAND almost 12 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from François ARMAND to Vincent MEMBRÉ

Some comments in the pull request, waiting for the next update !

Actions
Copy link
 #10

Updated by François ARMAND almost 12 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ almost 12 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Anonymous almost 12 years ago

Actions
Copy link
 #13

Updated by Nicolas PERRON almost 12 years ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF