Project

General

Profile

Actions
Copy link

Bug #3236

closed

Architecture #3232: Each Technique must follow our best-practices

The sshConfiguration Technique version 2.0 doesn't fully follow the convention

Added by Nicolas CHARLES about 11 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
2.6.1
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

The new convention states that :
The file containing all the variables should be name config.st and should call the bundle with the promises
The file main.st should be doing the actions, and should be plain CFEngine code

Related issues 1 (0 open — 1 closed)

Follows Rudder - User story #3100: Clean the sshConfiguration Technique with correct indentation, names and new conventionsReleasedMatthieu CERDA2012-12-20Actions
Actions
Copy link
 #1

Updated by Jonathan CLARKE about 11 years ago

  • Project changed from Rudder to 24
  • Category deleted (Techniques)
Actions
Copy link
 #2

Updated by Jonathan CLARKE about 11 years ago

  • Tracker changed from Bug to Enhancement
  • Category set to Techniques
  • Target version changed from 2.5.1 to 2.6.0~beta1

This will be built into the 2.6 version, not 2.5, since it's too much of a big change for a released version.

Adding this implementation ticket to the meta ticket #3232.

Actions
Copy link
 #3

Updated by Jonathan CLARKE about 11 years ago

  • Tracker changed from Enhancement to Bug
  • Target version changed from 2.6.0~beta1 to 2.5.1
  • Parent task set to #3232
Actions
Copy link
 #4

Updated by Jonathan CLARKE about 11 years ago

  • Tracker changed from Bug to Enhancement
  • Target version changed from 2.5.1 to 2.6.0~beta1
Actions
Copy link
 #5

Updated by Nicolas CHARLES about 11 years ago

  • Tracker changed from Enhancement to Bug
  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
Actions
Copy link
 #6

Updated by Nicolas CHARLES about 11 years ago

The PR has been updated

Actions
Copy link
 #7

Updated by Nicolas CHARLES about 11 years ago

Oh, I forgot to mention that the PR has been updated

Actions
Copy link
 #8

Updated by Nicolas CHARLES about 11 years ago

PR updated !

Actions
Copy link
 #9

Updated by Nicolas PERRON about 11 years ago

  • Target version changed from 2.6.0~beta1 to 2.6.0~rc1
Actions
Copy link
 #10

Updated by Nicolas CHARLES almost 11 years ago

Jon, could you do the technical review on this one, and merge it if you agree ?

Actions
Copy link
 #11

Updated by Jonathan CLARKE almost 11 years ago

  • Target version changed from 2.6.0~rc1 to 2.6.0
Actions
Copy link
 #12

Updated by Jonathan CLARKE almost 11 years ago

  • Target version changed from 2.6.0 to 2.6.1
Actions
Copy link
 #13

Updated by Nicolas CHARLES almost 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:60e04ee96aaafe3d59d3114390703508fd7b02ca.

Actions
Copy link
 #14

Updated by Nicolas CHARLES almost 11 years ago

Applied in changeset commit:04793a63f516a0dc21c449c949d931ded2c39850.

Actions
Copy link
 #15

Updated by Jonathan CLARKE almost 11 years ago

Applied in changeset commit:e5e155014bef70f6b2b8f34c0f6286d3187a45ee.

Actions
Copy link
 #16

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from Pending release to Released

This ticket has been adressed in the 2.6.1 release of Rudder.

The ChangeLog is available here: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26

Actions
Copy link

Also available in: Atom PDF