Bug #3245
closed
Techniques "Process Management" and "Set permissions on files": Wrong merge resulting in "policyInstanceId" variables in "Process Management" and "Set permissions on files"
Added by Nicolas PERRON almost 12 years ago.
Updated over 9 years ago.
Description
It seems that a wrong merge between branch 2.3 and 2.4 has result in presence of "policyInstanceId" variables in the new versions of the Techniques "Process Management" and "Set permissions on files".
Pull Request URL: https://github.com/Normation/rudder-techniques/pull/52
- Assignee set to Nicolas PERRON
- Description updated (diff)
- Status changed from New to Pending technical review
- % Done changed from 0 to 100
- Assignee changed from Nicolas PERRON to Jonathan CLARKE
Jon, could you review the pull request, please ?
Nicolas PERRON wrote:
Jon, could you review the pull request, please ?
Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.
Jonathan CLARKE wrote:
Nicolas PERRON wrote:
Jon, could you review the pull request, please ?
Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.
I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.
Nicolas PERRON wrote:
Jonathan CLARKE wrote:
Nicolas PERRON wrote:
Jon, could you review the pull request, please ?
Sure, I will do, but in the mean time can you please explain the impact of this bug, and change the title accordingly, please? This is formulated as a code bug, but I'm sure it has user impact. Please explain what that is here.
I didn't notice any impact for user and in the code, it seems logic that it has no impact. In fact this is more a refactoring than a bug.
OK that makes sense. Thanks for clarifying. I'll merge the PR.
- Status changed from Pending technical review to Pending release
Applied in changeset commit:0b207ae98598527aa4fde4f7bf20fe391e617435.
Applied in changeset commit:82e512275574333afb68da1ae5942757c09ce433.
- Status changed from Pending release to Released
- Project changed from 24 to Rudder
- Category changed from Techniques to Techniques
Also available in: Atom
PDF
Updated by Nicolas PERRON 
Updated by Jonathan CLARKE 
Updated by