Project

General

Profile

Actions
Copy link

User story #3449

closed

User story #3448: Improve perfs for manageFileAndFolder

Put data in an external file for manageFileAndFolder

Added by Nicolas CHARLES over 11 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
2.4.9
Pull Request:
https://github.com/Normation/rudder-t...
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

We need to put data in an external file for manageFileAndFolder

Caution, all data cannot be read from an external file (typically commands) for they may contains parsing char, or even have variable that wouldn't be expanded

Actions
Copy link
 #1

Updated by Nicolas CHARLES over 11 years ago

  • Status changed from In progress to 10
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/84
Actions
Copy link
 #2

Updated by Matthieu CERDA over 11 years ago

  • Target version changed from 2.3.12 to 2.3.13
Actions
Copy link
 #3

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 2.3.13 to 84
Actions
Copy link
 #4

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 84 to 2.4.7
Actions
Copy link
 #5

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 2.4.7 to 2.4.8
Actions
Copy link
 #6

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from 10 to Discussion
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES

I seem to recall that this has an undesirable side effect, making it impossible to use variables in any of the parameters here.

What shall we conclude? Should we reject this?

Actions
Copy link
 #7

Updated by Nicolas PERRON over 11 years ago

  • Target version changed from 2.4.8 to 2.4.9
Actions
Copy link
 #8

Updated by Nicolas CHARLES over 11 years ago

  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE

Hum, indeed there is the expansion problem, preventing to use CFEngine variables.
In this pull request, the fields at risks, read in external files, are:
FILE_AND_FOLDER_MANAGEMENT_PATH
FILE_AND_FOLDER_MANAGEMENT_OWNER
FILE_AND_FOLDER_MANAGEMENT_GROUP
FILE_AND_FOLDER_DELETION_DAYS

Removing these 4 would leave only 5 parameters in the external file, so it's probably not worth the pain

I'm closing the PR at least. Should we reject this ticket ?

Actions
Copy link
 #9

Updated by Nicolas CHARLES over 11 years ago

well no, I'm not closing the PR, if the ticket is not rejected I'll reuse it

Actions
Copy link
 #10

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Discussion to Rejected

Yes, let's reject this. I don't think the tradeoff is worth it - being fast is good, but it's no use if we can't do flexible and easy configuration, that's what Rudder's all about.

Actions
Copy link
 #11

Updated by Benoît PECCATTE over 9 years ago

  • Tracker changed from Enhancement to User story
Actions
Copy link

Also available in: Atom PDF