Project

General

Profile

Actions
Copy link

Bug #3465

closed

When popups are too tall or too wide, they are not displayed correctly

Added by Vincent MEMBRÉ over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
2
Assignee:
François ARMAND
Category:
Web - UI & UX
Target version:
2.6.0~rc1
Pull Request:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

Popups in Rudder grow very wide and tall with workflows activated ( Rules impacted + workflow + message = too much to be displayed)

We need to change the way we create those popups to allow them to be correctly displayed (adatped to height and width, then resized and centered to the page)

This bug only concerns 2.6 because popups get big enough only since then.

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from New to Pending technical review
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ over 11 years ago

  • Assignee changed from Vincent MEMBRÉ to François ARMAND
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Anonymous over 11 years ago

Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 11 years ago

Another pull request was made to make some other js correction https://github.com/Normation/rudder/pull/172

Actions
Copy link
 #6

Updated by Nicolas CHARLES over 11 years ago

Hum, just to be sure, doesn't it break some layout for popup ? I thought we had some kind of "policy" for popup width.height, that might get broken with this implementation, isn't it ?

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ over 11 years ago

by setting autoresize to true in the modal call, the size is dinamcally computed when resize events.

Before we had awful problems with huge popups (group/directive modification with change request activated...) and they were not visible in the browser.

AutoResize make it all work for us and adapt it to height/width of the window (can display popup on very very small browser and still access buttons and the top right corner close button)

The key is to call the resize.simplemodal event every time we want to update our popup

Actions
Copy link
 #8

Updated by Jonathan CLARKE over 11 years ago

  • Status changed from Pending release to Released
Actions
Copy link

Also available in: Atom PDF