User story #3490
closedAdapt the generic package_method from the cfengine_stdlib with individual package_changes
Description
All is in the title
Updated by Nicolas CHARLES over 11 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/95
Updated by Jonathan CLARKE over 11 years ago
- Status changed from Pending technical review to Discussion
- Target version changed from 2.5.3 to 2.7.0~beta1
I've looked at this Pull Request, and I see that it adds a rudder_generic package_method to our stdlib (by the way, I think this would be better named generic_individual, so then we could contribute it back to CFEngine).
However, at the moment, the Pull Request just adds this body, but never uses it. I think you should rework all the Techniques that use local package_methods to use this one instead. In the mean time, I'd rather not merge a commit that adds code that's not used, seeing as we are trying to stabilize the code currently.
Updated by Nicolas PERRON over 11 years ago
- Target version changed from 2.7.0~beta1 to 2.7.0~rc1
Any news for this issue ?
Updated by Nicolas PERRON over 11 years ago
- Status changed from Discussion to 8
- Target version changed from 2.7.0~rc1 to Ideas (not version specific)
Updated by Jonathan CLARKE over 11 years ago
- Assignee changed from Jonathan CLARKE to Nicolas PERRON
NicoC, what did you think about my feedback on this? I'd like to at least see the name of the body changed, and hopefully actually use it from Techniques too.
Updated by Jonathan CLARKE over 11 years ago
- Assignee changed from Nicolas PERRON to Nicolas CHARLES
Oops, wrong Nico.
Updated by Jonathan CLARKE over 11 years ago
Nicolas, this is blocking #3855 - can you provide an updated Pull Request or should we get someone else to work on this?
Updated by Nicolas CHARLES about 11 years ago
- Status changed from 8 to Discussion
- Assignee changed from Nicolas CHARLES to Jonathan CLARKE
Ha, sorry i didn't see the feedback
I was more planning to do it as a two way upgrade:
- create the body
- only then create new versions of techniques using it
otherwise the PR might get huge, and desynced with new versions of Technique coming up
Updated by Jonathan CLARKE about 11 years ago
- Assignee changed from Jonathan CLARKE to Nicolas CHARLES
- There is no point introducing a body package_method if we're not going to use it
- What is pressing here is getting a central package_method to fix bugs in, in particular for bug #3855. So, let's start by creating the central package_method, and using it in the rpmPackageInstallation and aptPackageInstallation techniques.
Go go go!
Updated by Jonathan CLARKE about 11 years ago
Updated by Matthieu CERDA over 10 years ago
- Status changed from Discussion to In progress
- Assignee changed from Nicolas CHARLES to Matthieu CERDA
Grabbin' this
Updated by Matthieu CERDA over 10 years ago
- Pull Request changed from https://github.com/Normation/rudder-techniques/pull/95 to https://github.com/Normation/rudder-techniques/pull/328
Taking NCH's PR as a reference
Updated by Matthieu CERDA over 10 years ago
- Target version changed from Ideas (not version specific) to 2.10.0
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.10.0 to 2.11.0~beta1
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.11.0~beta1 to 2.11.0~beta2
Updated by Matthieu CERDA over 10 years ago
- Target version changed from 2.11.0~beta2 to 2.11.0~rc1
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.11.0~rc1 to 2.11.0~rc2
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.11.0~rc2 to 2.11.0
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.11.0 to 2.11.1
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.11.1 to 2.11.2
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.11.2 to 2.11.3
Updated by Matthieu CERDA about 10 years ago
- Target version changed from 2.11.3 to 2.11.4
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.11.4 to 2.11.5
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.11.5 to 2.11.6
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.6 to 2.11.7
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.7 to 2.11.8
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.8 to 2.11.9
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.11.9 to 2.11.10
Updated by Benoît PECCATTE over 9 years ago
- Tracker changed from Enhancement to User story
Updated by François ARMAND over 9 years ago
- Status changed from In progress to 8
- Assignee deleted (
Matthieu CERDA)
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.10 to 2.11.11
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.11 to 2.11.12
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.12 to 2.11.13
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.13 to 2.11.14
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.14 to 2.11.15
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.15 to 2.11.16
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.16 to 2.11.17
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.17 to 2.11.18
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.11.18 to 2.11.19
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.11.19 to 2.11.20
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.20 to 2.11.21
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.21 to 2.11.23
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.23 to 2.11.24
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.24 to 308
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 308 to 3.1.14
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.14 to 3.1.15
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.15 to 3.1.16
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.16 to 3.1.17
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.17 to 3.1.18
Updated by Vincent MEMBRÉ almost 8 years ago
- Target version changed from 3.1.18 to 3.1.19
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.19 to 3.1.20
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.20 to 3.1.21
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.21 to 3.1.22
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.22 to 3.1.23
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.23 to 3.1.24
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 3.1.24 to 3.1.25
Updated by Benoît PECCATTE about 7 years ago
- Target version changed from 3.1.25 to 4.1.9
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 4.1.9 to 4.1.10
Updated by Benoît PECCATTE almost 7 years ago
- Target version changed from 4.1.10 to Ideas (not version specific)
Updated by Alexis Mousset over 6 years ago
- Status changed from New to Rejected
Old package methods are now deprecated, closing.