https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182013-06-04T16:15:11ZIssue TrackerRudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=178832013-06-04T16:15:11ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Discussion</i></li><li><strong>Assignee</strong> set to <i>Dennis Cabooter</i></li></ul><p>I'm not sure that it's necessary since after a test i've got this:<br /><pre>
[root@server ~]# yum install rudder-agent
[...]
********************************************************************************
rudder-agent has been installed (not started). This host can be a Rudder node.
To get started, configure your Rudder server's hostname and launch the agent:
# echo 'rudder.server' > /var/rudder/cfengine-community/policy_server.dat
# service rudder-agent start
This node will then appear in the Rudder web interface under 'Accept new nodes'.
********************************************************************************
Making a key pair for cfengine, please wait, this could take a minute...
Verifying : 1398866025:rudder-agent-2.6.1.release-1.EL.6.x86_64 1/2
Verifying : tokyocabinet-1.4.33-6.el6.x86_64 2/2
Installed:
rudder-agent.x86_64 1398866025:2.6.1.release-1.EL.6
Dependency Installed:
tokyocabinet.x86_64 0:1.4.33-6.el6
Complete!
[root@server ~]#
[root@server ~]# ps axf | grep cf
933 ? Ss 0:00 /sbin/dhclient -1 -q -cf /etc/dhcp/dhclient-eth0.conf -lf /var/lib/dhclient/dhclient-eth0.leases -pf /var/run/dhclient-eth0.pid eth0
2033 pts/0 S+ 0:00 \_ grep cf
[root@server ~]# service rudder-agent start
rudder-agent[2047]: [INFO] Using /etc/default/rudder-agent for configuration
rudder-agent[2050]: [INFO] Using /var/rudder/cfengine-community for CFEngine workdir
rudder-agent[2051]: [INFO] Launching CFEngine Community cf-serverd...
rudder-agent[2070]: [OK] CFEngine Community cf-serverd started after 1 seconds
rudder-agent[2071]: [INFO] Launching CFEngine Community cf-execd...
rudder-agent[2080]: [OK] CFEngine Community cf-execd started after 1 seconds
[root@server ~]# ps axf | grep cf
933 ? Ss 0:00 /sbin/dhclient -1 -q -cf /etc/dhcp/dhclient-eth0.conf -lf /var/lib/dhclient/dhclient-eth0.leases -pf /var/run/dhclient-eth0.pid eth0
2085 pts/0 S+ 0:00 \_ grep cf
2067 ? Ss 0:00 /var/rudder/cfengine-community/bin/cf-serverd
2077 ? Ss 0:00 /var/rudder/cfengine-community/bin/cf-execd
</pre></p>
<p>As we can see, rudder-agent is not stated after the installation of the package. I suggest to reject this bug, do you agree ?</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=178942013-06-05T07:33:29ZDennis Cabooterdcabooter@snow.nl
<ul></ul><p>On our RHEL 5.9 nodes this happens:</p>
<pre>[root@server ~]# echo 'rudder' > /var/rudder/cfengine-community/policy_server.dat
[root@server ~]# service rudder-agent start
rudder-agent[2894]: [INFO] Using /etc/default/rudder-agent for configuration
rudder-agent[2898]: [INFO] Using /var/rudder/cfengine-community for CFEngine workdir
rudder-agent[2899]: [INFO] Launching CFEngine Community cf-serverd...
Could not bind server address
!!! System reports error for bind: "Address already in use"
Could not bind server address
!!! System reports error for bind: "Address already in use"
Couldn't open bind an open socket
rudder-agent[2907]: [OK] CFEngine Community cf-serverd started after 1 seconds
rudder-agent[2908]: [INFO] Launching CFEngine Community cf-execd...
rudder-agent[2940]: [OK] CFEngine Community cf-execd started after 1 seconds</pre> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=178952013-06-05T07:35:07ZDennis Cabooterdcabooter@snow.nl
<ul></ul><p>And before that I see this message:</p>
<pre>rudder-agent[2266]: [INFO] Launching CFEngine Community cf-serverd...
rudder-agent[2286]: [OK] CFEngine Community cf-serverd started after 1 seconds
rudder-agent[2287]: [INFO] Launching CFEngine Community cf-execd...
rudder-agent[2297]: [OK] CFEngine Community cf-execd started after 1 seconds</pre> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=189432013-07-25T09:39:18ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>That is indeed weird, because the post-install script is quite clear that it will <strong>either</strong> print that message, <strong>or</strong> start rudder-agent, but not both.</p>
<p>If you did this on a machine that already has rudder-agent installed previously, this may explain this situation. Was that the case?</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=195092013-08-13T10:08:03ZMichael GliwinskiMichael.Gliwinski@gmail.com
<ul></ul><p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>That is indeed weird, because the post-install script is quite clear that it will <strong>either</strong> print that message, <strong>or</strong> start rudder-agent, but not both.</p>
<p>If you did this on a machine that already has rudder-agent installed previously, this may explain this situation. Was that the case?</p>
</blockquote>
<p>I just ran into this and I was indeed installing on a bunch of hosts that did have (an older version) of rudder-agent on in the past. I've noticed that cf-agent process was started from cron, I'm assuming this then started cf-serverd and cf-execd.</p>
<p>I can confirm that uninstalling rudder-agent does not remove <code>/etc/cron.d/rudder-agent</code> (nor the entry from <code>/etc/crontab</code> in older versions).</p>
<p>BTW, it also doesn't remove <code>/etc/rsyslog.d/rudder-agent.conf</code> and I found I need to restart rsyslog after installing and starting new version as otherwise reports weren't going to the new server.</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=197812013-08-28T13:35:34ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Project</strong> changed from <i>Rudder</i> to <i>34</i></li><li><strong>Subject</strong> changed from <i>Wrong install message on RHEL nodes</i> to <i>The Rudder agent post installation and removal scripts are not cleaning things correctly</i></li><li><strong>Status</strong> changed from <i>Discussion</i> to <i>In progress</i></li><li><strong>Assignee</strong> changed from <i>Dennis Cabooter</i> to <i>Matthieu CERDA</i></li><li><strong>Priority</strong> changed from <i>N/A</i> to <i>2</i></li><li><strong>Target version</strong> set to <i>2.4.8</i></li></ul><p>So this is a packaging issue, I'm correcting this, and making sure that the agent does not start when it should not.</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=197822013-08-28T14:02:11ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Status</strong> changed from <i>In progress</i> to <i>Pending technical review</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder-packages/pull/105</i></li></ul><p>PR available: <a class="external" href="https://github.com/Normation/rudder-packages/pull/105">https://github.com/Normation/rudder-packages/pull/105</a></p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=198372013-08-29T11:19:19ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul><p>Applied in changeset commit:4b52376ebafb49cfec55eb6819cb3af1b1df3b8b.</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=198382013-08-29T11:19:19ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Applied in changeset commit:5f02a6fb47525bbcde7a46d0b940c1adc9032484.</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=198872013-08-29T17:10:07ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Discussion</i></li><li><strong>Assignee</strong> changed from <i>Matthieu CERDA</i> to <i>Jonathan CLARKE</i></li></ul><p>Do we really want to rm -rdf <strong>/opt/rudder</strong> and <strong>/var/rudder</strong> after an uninstall ?</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=198912013-08-29T17:15:13ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Assignee</strong> changed from <i>Jonathan CLARKE</i> to <i>Matthieu CERDA</i></li></ul><p>Nicolas PERRON wrote:</p>
<blockquote>
<p>Do we really want to rm -rdf <strong>/opt/rudder</strong> and <strong>/var/rudder</strong> after an uninstall ?</p>
</blockquote>
<p>Hmmm. That is common practice for directories created by the packages, yes... But, now I come to think of it, if you remove rudder-agent on a Rudder server, that will remove all other files there (rudder-webapp, techniques, etc...)!</p>
<p>I guess we shouldn't do this. Let's try and be more precise with our rm -rf *...</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=201342013-09-02T09:21:57ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Discussion</i> to <i>Pending technical review</i></li></ul><p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>Nicolas PERRON wrote:</p>
<blockquote>
<p>Do we really want to rm -rdf <strong>/opt/rudder</strong> and <strong>/var/rudder</strong> after an uninstall ?</p>
</blockquote>
<p>Hmmm. That is common practice for directories created by the packages, yes... But, now I come to think of it, if you remove rudder-agent on a Rudder server, that will remove all other files there (rudder-webapp, techniques, etc...)!</p>
<p>I guess we shouldn't do this. Let's try and be more precise with our rm -rf *...</p>
</blockquote>
<p>This ticket can be set to "Pending release" again since <a class="issue tracker-1 status-5 priority-6 priority-low2 closed" title="Bug: The postrm script of Rudder-agent removes too much files (Released)" href="https://issues.rudder.io/issues/3896">#3896</a> solve the problem</p> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=201362013-09-02T09:24:05ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=202002013-09-03T12:52:42ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 2.4.8, which was released today.<br />Check out: </p>
<ul>
<li>The release announcement: <a class="external" href="http://www.rudder-project.org/pipermail/rudder-announce/2013-September/000044.html">http://www.rudder-project.org/pipermail/rudder-announce/2013-September/000044.html</a></li>
<li>The full ChangeLog: <a class="external" href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24">http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24</a></li>
<li>Download information: <a class="external" href="http://www.rudder-project.org/foswiki/Download/">http://www.rudder-project.org/foswiki/Download/</a></li>
</ul> Rudder - Bug #3634: The Rudder agent post installation and removal scripts are not cleaning things correctlyhttps://issues.rudder.io/issues/3634?journal_id=381302015-03-11T11:08:22ZBenoƮt PECCATTEbenoit.peccatte@rudder.io
<ul><li><strong>Project</strong> changed from <i>34</i> to <i>Rudder</i></li><li><strong>Category</strong> set to <i>Packaging</i></li></ul>