Project

General

Profile

Actions
Copy link

Bug #3639

closed

"Search nodes" screen: After a first use of the search button, it is no more clickable until a change (add/remove/modification) of criteria

Added by Nicolas CHARLES over 11 years ago. Updated over 11 years ago.

Status:
Released
Priority:
2
Assignee:
François ARMAND
Category:
Web - Nodes & inventories
Target version:
2.4.7
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I tried to make a search on node with a text fields (it was software name) and i had no result, so I changed my text, but the Search button didn't become clickable again (but the search result became gray, showing they where no longer valid)
Once we get to this point, no change (expect new lines) won't trigger the Search button to become cliackable again
Happens on 2.5 and 2.6

Actions
Copy link
 #1

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from New to In progress
  • Assignee set to Vincent MEMBRÉ
  • Priority changed from N/A to 2
  • Target version changed from 2.5.5 to 2.4.7

This happens on 2.4 too.

This is a javascript bug/css bug.

The button is clickable, but (disable property is removed) but disabled css are not removed.

The css are added by using Jquery UI ( We call the magic function "CorrectButtons()" that make pretty little buttons, which add the nice disabled css if the button is disabled)

But on search form we only remove the disabled attribute, without changing anything to classes.

To fix this two solutions :

  • keep the attribute remove, and call "CorrectButtons()"
  • use JqueryUI to remove the disabled which removes also the css.

I recommend the usage of the second.

$('#'+buttonId).button( "option", "disabled", false/true );});
Actions
Copy link
 #2

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/230
Actions
Copy link
 #3

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Anonymous over 11 years ago

Actions
Copy link
 #5

Updated by Nicolas PERRON over 11 years ago

  • Subject changed from When searchong node, after a search, when we have edit a string text, the search button doesn't become clickable again to On search nodes screen, After a first use of the search buttin, it is no more clickable until a change (add/remove/modification) of criteria
Actions
Copy link
 #6

Updated by Nicolas PERRON over 11 years ago

  • Subject changed from On search nodes screen, After a first use of the search buttin, it is no more clickable until a change (add/remove/modification) of criteria to "Search nodes" screen: After a first use of the search button, it is no more clickable until a change (add/remove/modification) of criteria
Actions
Copy link
 #7

Updated by Nicolas PERRON over 11 years ago

  • Status changed from Pending release to Released
Actions
Copy link
 #8

Updated by Nicolas PERRON over 11 years ago

This bug has been fixed in Rudder 2.4.7, which was released today.
Check out:

Actions
Copy link

Also available in: Atom PDF