Project

General

Profile

Actions
Copy link

Bug #3642

closed

CFEngine variables name in "CFEngine Generic Variable Definition" Directives no more support "dot" and need a migration script to "undot" existing ones

Bug #3642: CFEngine variables name in "CFEngine Generic Variable Definition" Directives no more support "dot" and need a migration script to "undot" existing ones

Added by Nicolas CHARLES over 12 years ago. Updated over 12 years ago.

Status:
Released
Priority:
2
Assignee:
François ARMAND
Category:
Web - Config management
Target version:
2.4.7
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

By fixing http://www.rudder-project.org/redmine/issues/3599, we enforced correctly content of variable name in the technique CFEngine Generic Variable Definition

However, it appears that the "dot" in the variable name is not considered an error by CFEngine if in a bundle common, hence exactly in the case of this techniques ( http://www.rudder-project.org/redmine/issues/3640 )
So we must provide a script to "fix" this "regression" by replacing "dot" by underscore in the variable name in directives based on Create a migration script to "undot" variable names in CFEngine Generic Variable Definition, and of course in the directives using these variables

Related issues 2 (0 open — 2 closed)

Related to Rudder - Bug #3640: Variable definition is not validRejectedNicolas CHARLESActions
Related to Rudder - Bug #5358: Webapp checking that CFEngine variables used in Directive are correct takes too much time at startupReleasedNicolas CHARLESActions

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #1

  • Target version changed from 84 to 2.4.7

Updated by Nicolas CHARLES over 12 years ago Actions
Copy link
 #2

This ticket is quite tricky, as we have to find all the variable name definition for directives based on this technique, replace the dot by something ( underscore), and then replace in other directives using this variable name (and it may be part of the field)

Updated by Nicolas CHARLES over 12 years ago Actions
Copy link
 #3

Updated by Nicolas CHARLES over 12 years ago Actions
Copy link
 #4

  • Status changed from New to In progress
  • Assignee set to Nicolas CHARLES

Updated by Nicolas CHARLES over 12 years ago Actions
Copy link
 #5

  • Status changed from In progress to Pending technical review
  • Assignee changed from Nicolas CHARLES to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/255

Francois, could you review this ?
https://github.com/Normation/rudder/pull/255

Updated by Nicolas CHARLES over 12 years ago Actions
Copy link
 #6

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Updated by Anonymous over 12 years ago Actions
Copy link
 #7

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #8

  • Subject changed from Create a migration script to "undot" variable names in CFEngine Generic Variable Definition to CFEngine variables name in "CFEngine Generic Variable Definition" Directives no more support "dot" and need a migration script to "undot" existing ones

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #9

  • Status changed from Pending release to Released

Updated by Nicolas PERRON over 12 years ago Actions
Copy link
 #10

This bug has been fixed in Rudder 2.4.7, which was released today.
Check out:

Actions
Copy link

Also available in: PDF Atom