User story #3752
closed
User Management: add an option to remove user home directory when deleting user account
Added by Dennis Cabooter over 11 years ago.
Updated almost 3 years ago.
Description
I've created a new feature in the userManagement technique. The feature makes it possible to pass the "-r" option to userdel and it works. However, I can't get the reporting right.
diff -Nru systemSettings/userManagement/userManagement/2.0/metadata.xml systemSettings/userManagement/userManagement/2.1/metadata.xml
--- systemSettings/userManagement/userManagement/2.0/metadata.xml 2013-06-11 16:09:35.000000000 +0200
+++ systemSettings/userManagement/userManagement/2.1/metadata.xml 2013-07-17 10:25:35.000000000 +0200
@@ -70,6 +70,10 @@
<VALUE>remove</VALUE>
</ITEM>
<ITEM>
+ <LABEL>Remove and delete home dir</LABEL>
+ <VALUE>removehome</VALUE>
+ </ITEM>
+ <ITEM>
<LABEL>Check only (account should exist)</LABEL>
<VALUE>checkhere</VALUE>
</ITEM>
diff -Nru systemSettings/userManagement/userManagement/2.0/userManagement.st systemSettings/userManagement/userManagement/2.1/userManagement.st
--- systemSettings/userManagement/userManagement/2.0/userManagement.st 2013-07-17 09:53:30.000000000 +0200
+++ systemSettings/userManagement/userManagement/2.1/userManagement.st 2013-07-17 13:21:08.000000000 +0200
@@ -91,6 +91,8 @@
"usermanagement_user_remove_${usergroup_user_index}" expression => strcmp("${usergroup_user_action[${usergroup_user_index}]}","remove");
+ "usermanagement_user_removehome_${usergroup_user_index}" expression => strcmp("${usergroup_user_action[${usergroup_user_index}]}","removehome");
+
"usermanagement_user_checkpres_${usergroup_user_index}" expression => strcmp("${usergroup_user_action[${usergroup_user_index}]}","checkhere");
"usermanagement_user_checkabs_${usergroup_user_index}" expression => strcmp("${usergroup_user_action[${usergroup_user_index}]}","checknothere");
@@ -157,6 +159,12 @@
comment => "Delete the user ${usergroup_user_login[${usergroup_user_index}]}",
ifvarclass => "usermanagement_user_exists_${usergroup_user_index}.usermanagement_user_remove_${usergroup_user_index}";
+ "/usr/sbin/userdel"
+ args => "-r ${usergroup_user_login[${usergroup_user_index}]}",
+ classes => cf2_if_else("usermanagement_login_remove_${usergroup_user_index}_repaired", "usermanagement_login_remove_${usergroup_user_index}_error"),
+ comment => "Delete the user ${usergroup_user_login[${usergroup_user_index}]}",
+ ifvarclass => "usermanagement_user_exists_${usergroup_user_index}.usermanagement_user_removehome_${usergroup_user_index}";
+
files:
"/etc/passwd"
- Project changed from Rudder to 24
- Category set to Techniques
Dennis,
Oh, indeed you need to change the reports part.
In the reports part, you have a # remove user section, with three reports (success, repaired and error), where reports are made if a combinaison of class is defined (or not defined), and if the class usermanagement_user_remove_${usergroup_user_index} exists
You could dupliate these lines, changing the text in the reports to say that it delete the home folder as well, and replace usermanagement_user_remove_${usergroup_user_index} by usermanagement_user_removehome_${usergroup_user_index}
Does that help you ?
- Subject changed from New feature userManagement technique to User Management: add an option to remove user home directory when deleting user account
- Status changed from New to Discussion
- Assignee set to Dennis Cabooter
- Status changed from Discussion to 13
- Assignee changed from Dennis Cabooter to Vincent MEMBRÉ
- Target version set to 2.4.10
Dennis, I'll create a pull request from your patch and I'll add Nicolas suggestion.
Thanks for your contribution Dennis!
- Target version changed from 2.4.10 to 2.4.11
- Target version changed from 2.4.11 to 2.4.12
- Target version changed from 2.4.12 to 2.4.13
- Target version changed from 2.4.13 to 2.6.11
Since 2.4 is not maintained anymore, retargeting to branch 2.6
- Target version changed from 2.6.11 to 2.6.12
- Target version changed from 2.6.12 to 2.6.13
- Target version changed from 2.6.13 to 2.6.14
- Target version changed from 2.6.14 to 2.6.16
- Target version changed from 2.6.16 to 2.6.17
- Target version changed from 2.6.17 to 2.6.18
- Target version changed from 2.6.18 to 2.6.19
- Target version changed from 2.6.19 to 2.6.20
- Status changed from 13 to Discussion
- Target version changed from 2.6.20 to 2.10.10
To be sure, the PR wasn't ever done, right ?
So, what are we doing with that? Is it still needed in 2.10 and up?
- Target version changed from 2.10.10 to 2.10.11
- Assignee changed from Vincent MEMBRÉ to Benoît PECCATTE
Benoit can you please look at it please !
- Target version changed from 2.10.11 to 2.10.12
- Project changed from 24 to Rudder
- Category changed from Techniques to Techniques
- Target version changed from 2.10.12 to 2.10.13
- Target version changed from 2.10.13 to 2.10.14
- Target version changed from 2.10.14 to 2.10.15
- Target version changed from 2.10.15 to 2.10.16
- Target version changed from 2.10.16 to 2.10.17
- Target version changed from 2.10.17 to 2.10.18
- Target version changed from 2.10.18 to 2.10.19
- Target version changed from 2.10.19 to 2.10.20
- Target version changed from 2.10.20 to 2.11.18
- Target version changed from 2.11.18 to 2.11.19
- Target version changed from 2.11.19 to 2.11.20
- Target version changed from 2.11.20 to 2.11.21
- Target version changed from 2.11.21 to 2.11.22
- Target version changed from 2.11.22 to 2.11.23
- Target version changed from 2.11.23 to 2.11.24
- Target version changed from 2.11.24 to 308
- Target version changed from 308 to 3.1.14
- Target version changed from 3.1.14 to 3.1.15
- Target version changed from 3.1.15 to 3.1.16
- Target version changed from 3.1.16 to 3.1.17
- Target version changed from 3.1.17 to 3.1.18
- Target version changed from 3.1.18 to 3.1.19
- Target version changed from 3.1.19 to 3.1.20
- Target version changed from 3.1.20 to 3.1.21
- Target version changed from 3.1.21 to 3.1.22
- Assignee deleted (
Benoît PECCATTE)
- Target version changed from 3.1.22 to 3.1.23
- Target version changed from 3.1.23 to 3.1.24
- Target version changed from 3.1.24 to 3.1.25
- Target version changed from 3.1.25 to 4.1.9
- Target version changed from 4.1.9 to 4.1.10
- Target version changed from 4.1.10 to Ideas (not version specific)
- Has duplicate User story #3971: Add an option to remove home folder when deleting a user with userManagement technique added
This won’t be added to that technique, please use the technique editor for that. If you are missing some capabilities in it, please open a ticket for that need.
- Status changed from Discussion to Rejected
Also available in: Atom
PDF