Project

General

Profile

Actions

Bug #3794

closed

"disable-agent" feature does not work as expected (doesn't stop *running* agents)

Added by Jonathan CLARKE over 9 years ago. Updated almost 8 years ago.

Status:
Released
Priority:
2
Category:
Packaging
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

As described in #3727, the /opt/rudder/etc/disable-agent file can be touched to disable the agent from being *re*started once it's stopped.

This is confusing, as it's name implied that the agent would actually be stopped, but it is not.

We should adapt this, maybe using some code like this (and setting "disable_agent" as an abortclass):

  classes:
    "should_disable_agent" expression => fileexists("${g.rudder_base}/etc/disable-agent");
    "disable_agent" 
      expression => "should_disable_agent",
      ifvarclass => "abort_report_done";

  processes:
    "cf-execd, cf-serverd, cf-monitord" 
       attributes => kill them;

  reports:
    should_disable_agent::
      "Report saying OMG the server and executor have been stopped, and the agent is going to be killed!" 
         classes => if_ok("abort_report_done");


Related issues 1 (0 open1 closed)

Related to Rudder - Architecture #3727: The cfengine processes management in system technique is splitted in various placesRejectedActions
Actions #1

Updated by Nicolas PERRON over 9 years ago

  • Status changed from Discussion to 8
Actions #2

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from 8 to Pending technical review
  • Assignee changed from Jonathan CLARKE to Nicolas CHARLES
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/160
Actions #3

Updated by Jonathan CLARKE over 9 years ago

  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/160 to https://github.com/Normation/rudder-techniques/pull/161/files

New PR, I screwed up the other one somehow: https://github.com/Normation/rudder-techniques/pull/161/files

Actions #4

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:b25cf3c824fe38ad1d1127330eaa8b00c7514a32.

Actions #5

Updated by Nicolas CHARLES over 9 years ago

Applied in changeset policy-templates:commit:d35dbc6dd6a950bc7fd92aad3b9e8fa0116bba1d.

Actions #6

Updated by Nicolas PERRON over 9 years ago

  • Project changed from Rudder to 34
  • Category deleted (System techniques)
Actions #7

Updated by Nicolas PERRON over 9 years ago

  • Status changed from Pending release to Released
Actions #8

Updated by Nicolas PERRON over 9 years ago

This bug has been fixed in Rudder 2.7.0, which was released today.
Check out:

Actions #9

Updated by Benoît PECCATTE almost 8 years ago

  • Project changed from 34 to Rudder
  • Category set to Packaging
Actions

Also available in: Atom PDF