https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182013-08-26T13:03:49ZIssue TrackerRudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=197042013-08-26T13:03:49ZNicolas PERRONnicolas.perron@normation.com
<ul></ul><p>A first pass is to use this command:<br /><pre>
find techniques/ -name "*.st" -exec sed -r 's@^(\s+"[^"]*"),$@\1@' -i {} \;
</pre></p>
But some files will need to undo modifications:
<ul>
<li>techniques/fileConfiguration/fileSecurity/filesPermissions/{1.0,1.1}/filesPermissions.st</li>
<li>techniques/jobScheduling/jobScheduler/1.0/job_scheduler.st</li>
<li>techniques/system/common/1.0/cf-served.st</li>
<li>techniques/system/common/1.0/promises.st</li>
<li>techniques/systemSettings/process/processManagement/1.0/processManagement.st</li>
<li>techniques/systemSettings/remoteAccess/sshKeyDistribution/1.0/sshKeyDistribution.st</li>
</ul>
<p>And the new CFEngine standard library will need to be upgraded to the CFEngine 3.5.1 one.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=199942013-08-30T17:10:58ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Target version</strong> changed from <i>2.4.8</i> to <i>2.4.9</i></li></ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205472013-09-19T13:26:25ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>13</i></li><li><strong>Assignee</strong> set to <i>Nicolas PERRON</i></li></ul><p>Nicolas PERRON wrote:</p>
<blockquote>
<p>A first pass is to use this command:<br />[...]</p>
But some files will need to undo modifications:
<ul>
<li>techniques/fileConfiguration/fileSecurity/filesPermissions/{1.0,1.1}/filesPermissions.st</li>
<li>techniques/jobScheduling/jobScheduler/1.0/job_scheduler.st</li>
<li>techniques/system/common/1.0/cf-served.st</li>
<li>techniques/system/common/1.0/promises.st</li>
<li>techniques/systemSettings/process/processManagement/1.0/processManagement.st</li>
<li>techniques/systemSettings/remoteAccess/sshKeyDistribution/1.0/sshKeyDistribution.st</li>
</ul>
<p>And the new CFEngine standard library will need to be upgraded to the CFEngine 3.5.1 one.</p>
</blockquote>
<p>Arg... my modifications was on the wrong branch.</p>
On branch 2.4 the modifications is a little different. Some more files to undo modificatios:
<ul>
<li>techniques/fileDistribution/copyGitFile/1.4/copyFileFromSharedFolder.st</li>
<li>techniques/systemSettings/process/processManagement/1.1/processManagement.st</li>
</ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205482013-09-19T13:28:50ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Tracker</strong> changed from <i>Architecture</i> to <i>Bug</i></li></ul><p>This is more a bug than an architecture issue. The promises are broken for CFEngine 3.5</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205512013-09-19T14:34:41ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder-techniques/pull/190</i></li></ul><p>I need to test that this is not broken but the Pull Request is here:<br /><a class="external" href="https://github.com/Normation/rudder-techniques/pull/190">https://github.com/Normation/rudder-techniques/pull/190</a></p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205642013-09-19T17:00:24ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Assignee</strong> changed from <i>Nicolas PERRON</i> to <i>Jonathan CLARKE</i></li></ul><p>Nicolas PERRON wrote:</p>
<blockquote>
<p>I need to test that this is not broken but the Pull Request is here:<br /><a class="external" href="https://github.com/Normation/rudder-techniques/pull/190">https://github.com/Normation/rudder-techniques/pull/190</a></p>
</blockquote>
<p>Seems OK. Jon, could you review it please ?</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205652013-09-19T17:00:35ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205662013-09-19T17:00:53ZNicolas PERRONnicolas.perron@normation.com
<ul></ul><p>(I can't change the status of this issue !)</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205712013-09-20T08:30:35ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Assignee</strong> changed from <i>Jonathan CLARKE</i> to <i>Nicolas PERRON</i></li></ul><p>I have reviewed the Pull Request and approve it.</p>
<p>However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.</p>
The upgrade process should be, for 2.8 specifically:
<ul>
<li>Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*</li>
<li>Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)</li>
<li>Upgrade <strong>all</strong> agents connected to that server to 2.8.*</li>
<li>Upgrade the Rudder server to 2.8</li>
</ul>
<p>Can you do this please Nico? Then merge this PR.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=205722013-09-20T08:30:50ZJonathan CLARKEjonathan.clarke@normation.com
<ul><li><strong>Project</strong> changed from <i>24</i> to <i>Rudder</i></li><li><strong>Category</strong> set to <i>System techniques</i></li></ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=206992013-09-24T12:51:50ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>% Done</strong> changed from <i>100</i> to <i>80</i></li></ul><p>This issue had invalid status_id for this tracker, breaking completely Redmine's status selector. I fixed it directly in SQL.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=208372013-10-01T17:21:58ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Target version</strong> changed from <i>2.4.9</i> to <i>2.4.10</i></li></ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=208982013-10-02T10:45:09ZNicolas PERRONnicolas.perron@normation.com
<ul></ul><p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>I have reviewed the Pull Request and approve it.</p>
<p>However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.</p>
The upgrade process should be, for 2.8 specifically:
<ul>
<li>Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*</li>
<li>Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)</li>
<li>Upgrade <strong>all</strong> agents connected to that server to 2.8.*</li>
<li>Upgrade the Rudder server to 2.8</li>
</ul>
<p>Can you do this please Nico? Then merge this PR.</p>
</blockquote>
<p>So if I've understood you want me to add a documentation on 2.8 before the merge of this bug fix ? I don't understand why since the code does not depend on the documentation.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=209082013-10-02T13:27:16ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Nicolas PERRON wrote:</p>
<blockquote>
<p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>I have reviewed the Pull Request and approve it.</p>
<p>However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.</p>
The upgrade process should be, for 2.8 specifically:
<ul>
<li>Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*</li>
<li>Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)</li>
<li>Upgrade <strong>all</strong> agents connected to that server to 2.8.*</li>
<li>Upgrade the Rudder server to 2.8</li>
</ul>
<p>Can you do this please Nico? Then merge this PR.</p>
</blockquote>
<p>So if I've understood you want me to add a documentation on 2.8 before the merge of this bug fix ? I don't understand why since the code does not depend on the documentation.</p>
</blockquote>
<p>Because I have often formulated similar comments in the past, then the PR or ticket has been closed, and my comments forgotten. This way, I know they won't be :)</p>
<p>I've merged the doc PR from <a class="issue tracker-2 status-5 priority-7 priority-lowest closed child" title="User story: Update documentation about the upgrade process for Rudder 2.8 (Released)" href="https://issues.rudder.io/issues/3987">#3987</a>. I'll merge this now too.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=209092013-10-02T13:27:51ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Discussion</i> to <i>Pending release</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>100</i></li></ul><p>Applied in changeset policy-templates:commit:12a8ae4cb0b905890707af0cf45a945738594662.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=209102013-10-02T13:27:51ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Applied in changeset policy-templates:commit:3107a08b9fae50148fde5912e6e18d1be2f63935.</p> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=209632013-10-02T15:41:02ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Target version</strong> changed from <i>2.4.10</i> to <i>2.4.9</i></li></ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=210682013-10-03T17:03:01ZNicolas PERRONnicolas.perron@normation.com
<ul></ul><p>This bug has been fixed in Rudder 2.4.9, which was released today.<br />Check out: </p>
<ul>
<li>The release announcement: <a class="external" href="http://www.rudder-project.org/pipermail/rudder-announce/2013-October/000049.html">http://www.rudder-project.org/pipermail/rudder-announce/2013-October/000049.html</a></li>
<li>The full ChangeLog: <a class="external" href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24">http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24</a></li>
<li>Download information: <a class="external" href="http://www.rudder-project.org/foswiki/Download/">http://www.rudder-project.org/foswiki/Download/</a></li>
</ul> Rudder - Bug #3871: Remove the comma after the promisers from all Techniqueshttps://issues.rudder.io/issues/3871?journal_id=210802013-10-03T17:06:37ZNicolas PERRONnicolas.perron@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul>