Bug #3871
closed
Remove the comma after the promisers from all Techniques
Added by Nicolas PERRON over 11 years ago.
Updated over 11 years ago.
Category:
System techniques
Description
We've got comma just after the promiser into some Techniques which is syntactically wrong.
Until CFEngine 3.5 this is only tolerate then we have to change it especially if we want to integrate CFEngine 3.5 !
A first pass is to use this command:
find techniques/ -name "*.st" -exec sed -r 's@^(\s+"[^"]*"),$@\1@' -i {} \;
But some files will need to undo modifications:
- techniques/fileConfiguration/fileSecurity/filesPermissions/{1.0,1.1}/filesPermissions.st
- techniques/jobScheduling/jobScheduler/1.0/job_scheduler.st
- techniques/system/common/1.0/cf-served.st
- techniques/system/common/1.0/promises.st
- techniques/systemSettings/process/processManagement/1.0/processManagement.st
- techniques/systemSettings/remoteAccess/sshKeyDistribution/1.0/sshKeyDistribution.st
And the new CFEngine standard library will need to be upgraded to the CFEngine 3.5.1 one.
- Target version changed from 2.4.8 to 2.4.9
- Status changed from New to 13
- Assignee set to Nicolas PERRON
Nicolas PERRON wrote:
A first pass is to use this command:
[...]
But some files will need to undo modifications:
- techniques/fileConfiguration/fileSecurity/filesPermissions/{1.0,1.1}/filesPermissions.st
- techniques/jobScheduling/jobScheduler/1.0/job_scheduler.st
- techniques/system/common/1.0/cf-served.st
- techniques/system/common/1.0/promises.st
- techniques/systemSettings/process/processManagement/1.0/processManagement.st
- techniques/systemSettings/remoteAccess/sshKeyDistribution/1.0/sshKeyDistribution.st
And the new CFEngine standard library will need to be upgraded to the CFEngine 3.5.1 one.
Arg... my modifications was on the wrong branch.
On branch 2.4 the modifications is a little different. Some more files to undo modificatios:
- techniques/fileDistribution/copyGitFile/1.4/copyFileFromSharedFolder.st
- techniques/systemSettings/process/processManagement/1.1/processManagement.st
- Tracker changed from Architecture to Bug
This is more a bug than an architecture issue. The promises are broken for CFEngine 3.5
- % Done changed from 0 to 90
- Pull Request set to https://github.com/Normation/rudder-techniques/pull/190
- Assignee changed from Nicolas PERRON to Jonathan CLARKE
- % Done changed from 90 to 100
(I can't change the status of this issue !)
- Assignee changed from Jonathan CLARKE to Nicolas PERRON
I have reviewed the Pull Request and approve it.
However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.
The upgrade process should be, for 2.8 specifically:
- Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*
- Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)
- Upgrade all agents connected to that server to 2.8.*
- Upgrade the Rudder server to 2.8
Can you do this please Nico? Then merge this PR.
- Project changed from 24 to Rudder
- Category set to System techniques
- % Done changed from 100 to 80
This issue had invalid status_id for this tracker, breaking completely Redmine's status selector. I fixed it directly in SQL.
- Target version changed from 2.4.9 to 2.4.10
Jonathan CLARKE wrote:
I have reviewed the Pull Request and approve it.
However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.
The upgrade process should be, for 2.8 specifically:
- Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*
- Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)
- Upgrade all agents connected to that server to 2.8.*
- Upgrade the Rudder server to 2.8
Can you do this please Nico? Then merge this PR.
So if I've understood you want me to add a documentation on 2.8 before the merge of this bug fix ? I don't understand why since the code does not depend on the documentation.
Nicolas PERRON wrote:
Jonathan CLARKE wrote:
I have reviewed the Pull Request and approve it.
However, this change is very important for the upgrade process from 2.* to 2.8 (which will contain CFEngine 3.5.*): since we recommend that users upgrade all agents before upgrading the server, this would break unless the server is using a version including this fix. So, please note which minimal versions of Rudder include this fix (I'm assuming 2.4.9, 2.6.6 and 2.7.3), and update the upgrade documentation in the 2.8 branch accordingly.
The upgrade process should be, for 2.8 specifically:
- Make sure the Rudder server to be upgraded is in a version that is at least 2.4.9, 2.6.6 and 2.7.3 before attempting to upgrade to 2.8.*
- Ensure that all nodes' promises have been regenerated since the server upgrade to this version (do we do this automatically on package upgrade now? if so, ignore, if not explain how to do it)
- Upgrade all agents connected to that server to 2.8.*
- Upgrade the Rudder server to 2.8
Can you do this please Nico? Then merge this PR.
So if I've understood you want me to add a documentation on 2.8 before the merge of this bug fix ? I don't understand why since the code does not depend on the documentation.
Because I have often formulated similar comments in the past, then the PR or ticket has been closed, and my comments forgotten. This way, I know they won't be :)
I've merged the doc PR from #3987. I'll merge this now too.
- Status changed from Discussion to Pending release
- % Done changed from 80 to 100
Applied in changeset policy-templates:commit:12a8ae4cb0b905890707af0cf45a945738594662.
Applied in changeset policy-templates:commit:3107a08b9fae50148fde5912e6e18d1be2f63935.
- Target version changed from 2.4.10 to 2.4.9
This bug has been fixed in Rudder 2.4.9, which was released today.
Check out:
- Status changed from Pending release to Released
Also available in: Atom
PDF
Updated by Nicolas PERRON over 11 years ago
Updated by Jonathan CLARKE over 11 years ago
Updated by Matthieu CERDA