User story #3875: In directive editor for file permission, add the possibility to set SUID, SGID and sticky bit - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

User story #3875

closed

In directive editor for file permission, add the possibility to set SUID, SGID and sticky bit

Added by Nicolas PERRON about 11 years ago. Updated over 2 years ago.

Status:

Resolved

Priority:

N/A

Assignee:

Category:

Web - Config management

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

In order to simplify the code which permit to have the SUID and SGID on file, we need to implement it into the code of Rudder into the module perm

Subtasks 1 (0 open — 1 closed)

User story #3876: Add the SUID and SGID into the perm module of Rudder

Rejected

Actions

Related issues 5 (1 open — 4 closed)

Related to Rudder - User story #3115: Technique "Download From A Shared Folder": Add possibility to set SUID and SGID to files copied	Released	Nicolas PERRON	2013-08-21	Actions
Related to Rudder - Bug #5325: Technique "Set the permissions on files": We can't set the SUID/SGID	Released	Jonathan CLARKE	2014-07-29	Actions
Related to Rudder - User story #3141: Implement the SUID and SGID handling in the filePermissions Technique	Released	Nicolas CHARLES	2013-01-07	Actions
Related to Rudder - User story #6247: Add sticky bit to technique Manage files and folders	New			Actions
Has duplicate Rudder - User story #8694: The perm input type should include suid bits	Rejected		2016-07-15	Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

This is the continuity of #3115

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Subject changed from CFEngine integration: Add possibility to set SUID and SGID to files copied to CFEngine integration: Add possibility to set SUID, SGID and sticky bit to files copied

To clarify, the aim here is to edit the "perm" module that is in Scala code, and displayed in a Directive when the variable constraint is "perm". We want to add 3 fields (checkboxes) to it "Set user ID (suid)" and "Set group ID (sgid)" and "Set sticky bit".

The result of the perm module is a octal code, currently something like 777, 740, 640, etc. Adding these checkboxes should add another digit to these numbers, so they would become 2777 (777 + sgid) or 4740 (740 + suid) or 7640 (640 + suid + sgid + sticky). The algo for this is as follows:

If suid, result += 4000
If sgid, result += 2000
If sticky, result += 1000

If none of the 3 new fields are ticked (they should default to "no"), it is acceptable to return the result with or without a leading 0 : "740" and "0740" are equivalent.

See: http://linux.die.net/man/1/chmod

Actions

Copy link

Updated by François ARMAND about 11 years ago

Assignee changed from François ARMAND to Nicolas PERRON

Not sure why I'm the assignee for this one ?
Nicolas, have you an idea ?

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Assignee changed from Nicolas PERRON to François ARMAND

François ARMAND wrote:

Not sure why I'm the assignee for this one ?
Nicolas, have you an idea ?

Because you're the lead developper and you know who is the best person to deal with this issue. Am I wrong ?

Actions

Copy link

Updated by François ARMAND about 11 years ago

Subject changed from CFEngine integration: Add possibility to set SUID, SGID and sticky bit to files copied to In directive editor for file permission, add the possibility to set SUID, SGID and sticky bit

OK, but for now, it wasn't even in the roadmap for 2.8. Let's discuss that before.

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

François ARMAND wrote:

OK, but for now, it wasn't even in the roadmap for 2.8. Let's discuss that before.

Unless I'm very much mistaken, this is rather a small change. It's currently implemented through some nastyish CFEngine hacks. Please add it to the roadmap for 2.8 :)

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Target version changed from 2.8.0~beta1 to 2.8.0~rc1

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Target version changed from 2.8.0~rc1 to Ideas (not version specific)

This won't be done for Rudder 2.8.0

postponed to a later version.

Actions

Copy link

Updated by Nicolas CHARLES over 10 years ago

Target version changed from Ideas (not version specific) to 2.10.0

I guess it would make sense to add it in 2.10

Actions

Copy link

#10

Updated by Nicolas CHARLES over 10 years ago

Francois,
I had a look at the code, and it seems much more complex that I foresaw, and I'd need your advice.
Do you think it make sence to create a new type Sticky, a bit like Perm, to be sure we don't confuse both, and end up writing rrwxrwxrwx instead of 4rwxrwxrwx ?
if so, how could it nicely fit into the FilePerms and PermSet objects (i'm facing combinatory explosion there)?

Actions

Copy link

#11