Rudder

It seems that our pre and post uninstall needs some rework. As said in http://www.ibm.com/developerworks/library/l-rpm2/:

[...] the order of operations during an upgrade is:

   1. Run the %pre section of the RPM being installed.
   2. Install the files that the RPM provides.
   3. Run the %post section of the RPM.
   4. Run the %preun of the old package.
   5. Delete any old files not overwritten by the newer version. (This step deletes files that the new package does not require.)
   6. Run the %postun hook of the old package.

Steps 4 and 6 may seem a bit suspect, and for good reason: If you are upgrading a package, running the older version's uninstallation hooks could undo portions or all of steps 1 through 3.[...] To prevent unintentional clobbering, RPM passes each hook one argument, a flag. The value of the flag indicates which operation is being performed:

    If the first argument to %pre is 1, the RPM operation is an initial installation. If the argument to %pre is 2, the operation is an upgrade from an existing version to a new one.
    Similarly, the arguments to a %post are 1 and 2 for a new installation and upgrade, respectively. (Again, %pre and %post aren't executed during an uninstallation.)
    If the first argument to %preun and %postun is 1, the action is an upgrade.
    If the first argument to %preun and %postun is 0, the action is uninstallation.

And we don't use these flags:

%preun -n rudder-agent
#=================================================
# Pre Uninstallation
#=================================================

# Keep a backup copy of uuid.hive
mkdir -p /var/backups/rudder
cp -f /opt/rudder/etc/uuid.hive /var/backups/rudder/uuid-$(date +%Y%m%d).hive
echo "INFO: A back up copy of the /opt/rudder/etc/uuid.hive has been created in /var/backups/rudder" 

%postun -n rudder-agent
#=================================================
# Post Uninstallation
#=================================================

# Make sure that CFEngine is not running anymore
for component in cf-agent cf-serverd cf-execd cf-monitord; do
    kill -9 `pidof ${component}`
done

# Remove the cron script we create at installation to prevent mail
# flooding, re-installation surprises, and general system garbage.
rm -f /etc/cron.d/rudder-agent

# Make sure that Rudder agent specific files have been removed
rm -f /etc/init.d/rudder-agent
rm -f /etc/default/rudder-agent
rm -f /opt/rudder/etc/uuid.hive

I'll work on this issue

I've tested all these flags and they work !

Pull Request URL added: https://github.com/Normation/rudder-packages/pull/118

It concerns Rudder v2.6+

Jon, the backup of the uuid file is made during upgrade and uninstall on Debian but only during uninstall on RPM.

What should we do ? This is harmless to backup a file (the worst case could be: too many files) and I prefer to backup even during an upgrade. What's your opinion ?

Matthieu CERDA wrote:

Do a backup in any case. Seriously. :)

It is much safer this way, and you might want to backup ppkeys too.

Agreed. If in doubt, err on the side of safety.

PR validated, looks fine to me, but I understand you may want to change it now, so I haven't merged it yet.

Jonathan CLARKE wrote:

Matthieu CERDA wrote:

Do a backup in any case. Seriously. :)

It is much safer this way, and you might want to backup ppkeys too.

Agreed. If in doubt, err on the side of safety.

PR validated, looks fine to me, but I understand you may want to change it now, so I haven't merged it yet.

As you said, I needed to rework it.

This is done. Could you review it again, please ?

Applied in changeset commit:70203d4e3eb27a8962ca361ead5c4d0e48599b4f.

This issue affect 2.4.8 too ! see #3864 and #3896.

I'll revert this commit to reapply it to branch 2.4.

Hmm... revert it is useless. It was possible to cherry-pick the commits from branch 2.6.

Applied in changeset commit:f33f5607e5d88be3df8a4470d61f8e36ec8d31b3.