User story #3948: Add warning when saving a Rule with no groups nor directives - Rudder - Issue Tracker

Actions

Copy link

User story #3948

closed

User story #3937: When saving a Rule without target groups or directives, display a warning message

Add warning when saving a Rule with no groups nor directives

Added by Vincent MEMBRÉ over 10 years ago. Updated about 9 years ago.

Status:

Released

Priority:

Assignee:

François ARMAND

Category:

Web - Config management

Target version:

2.8.0~beta1

Pull Request:

https://github.com/Normation/rudder/p...

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

When modifying a Rule and removing all directives/groups, the Rules is not applied.

But the popup says that everything is fine and that the Rule will be applied.

This is wrong!

As Jon said in #3937 :

This user story should add a small warning to the confirmation popup, so it reads somethings like this:

--------------8<----------------------
Rule saved successfully*
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.**
--------------8<----------------------

Don't change this text, leave it as is, I just don't remember it right now
If there are groups but not Directives, this should read "This Rule does not have any Directives to apply. No configuration policy will be deployed."

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Status changed from In progress to Discussion
Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

Only have one question : If there is no groups and no directives linked to the Rule the popup should display one or to message ?

ie:

Rule saved successfully
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.
WARNING: This Rule does not have any Directives to apply. No configuration policy will be deployed.

Rule saved successfully
WARNING: This Rule is not applied to any Groups and does not have any Directives to apply. No configuration policy will be deployed.

I think the first one is better (line too long and complicated for the last one).

Jon what do you think of it ?

Actions

Copy link