Project

General

Profile

Actions

User story #3948

closed

User story #3937: When saving a Rule without target groups or directives, display a warning message

Add warning when saving a Rule with no groups nor directives

Added by Vincent MEMBRÉ over 11 years ago. Updated over 9 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Config management
Target version:
UX impact:
Suggestion strength:
User visibility:
Effort required:
Name check:
Fix check:
Regression:

Description

When modifying a Rule and removing all directives/groups, the Rules is not applied.

But the popup says that everything is fine and that the Rule will be applied.

This is wrong!

As Jon said in #3937 :

This user story should add a small warning to the confirmation popup, so it reads somethings like this:

--------------8<----------------------
Rule saved successfully*
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.**
--------------8<----------------------

Don't change this text, leave it as is, I just don't remember it right now
If there are groups but not Directives, this should read "This Rule does not have any Directives to apply. No configuration policy will be deployed." 
Actions #1

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from In progress to Discussion
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

Only have one question : If there is no groups and no directives linked to the Rule the popup should display one or to message ?

ie:

Rule saved successfully
WARNING: This Rule is not applied to any Groups. No configuration policy will be deployed.
WARNING: This Rule does not have any Directives to apply. No configuration policy will be deployed.

or

Rule saved successfully
WARNING: This Rule is not applied to any Groups and does not have any Directives to apply. No configuration policy will be deployed.

I think the first one is better (line too long and complicated for the last one).

Jon what do you think of it ?

Actions #2

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from Discussion to 10
  • Pull Request set to https://github.com/Normation/rudder/pull/319

Adding pull request,

need fonctionnal review before tech review.

Actions #3

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from 10 to In progress
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ

I discussed with Jon about which warning to use and we finally choose the one line style:

WARNING: This Rule is not applied to any Groups and does not have any Directives to apply. No configuration policy will be deployed

Actions #4

Updated by Vincent MEMBRÉ over 11 years ago

  • Status changed from In progress to 10
  • Assignee changed from Vincent MEMBRÉ to François ARMAND

Functionnal review done with Jon, Can someone change to Technical review ? :(

Pull request here: https://github.com/Normation/rudder/pull/319

Assigned to François about the technical review

Actions #5

Updated by Jonathan CLARKE about 11 years ago

  • Status changed from 10 to Pending technical review
Actions #6

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #7

Updated by Vincent MEMBRÉ about 11 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.8.0~beta1, which was released today.
Check out:

Actions #8

Updated by Benoît PECCATTE over 9 years ago

  • Tracker changed from Enhancement to User story
Actions

Also available in: Atom PDF