Rudder

to repair a broken change request run this psql query :

update changerequest set content = xmlparse( document replace(XMLSERIALIZE (DOCUMENT content as text), chr(13), '
')) where id = x;

Are we sure we are escaping all invalid XML chars ? There is no point on escaping only "\r" if other chars could lead to the same behaviour.

In fact, there is in Scala scala.xml.Utility.escape / unescape. And we shoudl use it when we are saving in XML... And unescaping on deserialisation.

Whell, so the bug seems far more involved than what is shown here. I don't have a clear vision about how to adress that for now (inpact is huge... We use XML in a lot of place...)

Here is a stack overflow answer about invalid characters in XML: http://stackoverflow.com/questions/730133/invalid-characters-in-xml

Char       ::=      #x9 | #xA | #xD | [#x20-#xD7FF] | [#xE000-#xFFFD] | [#x10000-#x10FFFF]  /* any Unicode character, excluding the surrogate blocks, FFFE, and FFFF. */

\r is in this list #xD (\n too #xA)

List in previous comment is about valid characters,

so \r and \n are valid characters, but numerous xml parsers replace \r by an \n (see www.w3.org/TR/xml/#sec-common-syn)

To fix our problem here, we will normalize datas by serializing into xml datas from LDAP and deserializing then right after to get them into the same state than datas in change request.

I added a commit to trim directive parameters(if an \r was inserted it was trimmed in LDAP but not in psql...)

François, if it's ok, don't merge so i can rebase it.

Applied in changeset f8a6ed0efeea418848f39e1382d04a4f1a891e87.