Bug #4040: Remove comma after the promiser from passwordCheck in the distirbutePolicy promises - Rudder - Issue Tracker

Custom queries

8.1 beta
Bugs triage
CS - by priority
CS - to review
My TR
Need technical review
Open bugs (all)
Open bugs (UI - UX)
Open UX defects (all)
Opened by users

Actions

Copy link

Bug #4040

closed

Remove comma after the promiser from passwordCheck in the distirbutePolicy promises

Added by Nicolas PERRON about 11 years ago. Updated over 9 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Techniques

Target version:

2.4.12

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

A comma after promiser remains from the fix of #3871 which will prevent Rudder server to regenerate its promises on Rudder 2.8

Related issues 2 (0 open — 2 closed)

	Related to Rudder - User story #3869: Integration of CFEngine 3.5.* into Rudder	Released	Nicolas PERRON	2013-10-03			Actions
	Related to Rudder - Bug #4042: Remove comma after the promiser from passwordCheck in the distirbutePolicy inital promises	Released	Jonathan CLARKE	2013-10-10			Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Project changed from 34 to 24

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Status changed from New to Pending technical review
Assignee changed from Nicolas PERRON to Jonathan CLARKE
% Done changed from 0 to 100
Pull Request set to https://github.com/Normation/rudder-techniques/pull/210

The consequence will be that the migration to Rudder 2.8 will only be possible from Rudder 2.4.12, 2.6.9 and 2.7.6...

Pull Request URL added: https://github.com/Normation/rudder-techniques/pull/210

Jon, could you review it please ?

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Nicolas PERRON wrote:

The consequence will be that the migration to Rudder 2.8 will only be possible from Rudder 2.4.12, 2.6.9 and 2.7.6...

Erm, I'm not sure about that actually - this comma is in the distributePolicy Technique, which by definition is only used on the policy servers (and before 2.8, there could only be a single root policy server). So we don't have to worry about this "broken" promise being on nodes, because it can't be! So in effect, when a Rudder root server is upgraded, the system Techniques including distributePolicy will also be upgraded, and the promises regenerated! Easy :)

However, on the first run(s) of cf-agent, this might cause trouble, in the short period of time in between the rudder-agent upgrade to 3.5.* and the promise regeneration for the policy server. So I agree we should include this fix in older branches, but I don't think we need to change the upgrading procedure.

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Status changed from Pending technical review to Pending release

Applied in changeset commit:e2afbedaa9a4b44f0e8cb97e35ec7df028c81331.

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Applied in changeset commit:6250d63efb70ec3fbfab1e0578e66d021029f4d8.

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

This issue is linked to the integration of CFE 3.5 #3869

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

This change will require the same change one the initial promises: #4042

Actions

Copy link

Updated by Nicolas PERRON about 11 years ago

Status changed from Pending release to Released

This bug has been fixed in Rudder 2.4.12 which was released today.
Check out:

The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2013-November/000061.html
The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog24
Download information: https://www.rudder-project.org/site/get-rudder/downloads/

Actions

Copy link

Updated by Benoît PECCATTE over 9 years ago

Project changed from 24 to Rudder
Category set to Techniques

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

Rudder

Custom queries

Bug #4040

Remove comma after the promiser from passwordCheck in the distirbutePolicy promises

Updated by Nicolas PERRON about 11 years ago

Updated by Nicolas PERRON about 11 years ago

Updated by Jonathan CLARKE about 11 years ago

Updated by Nicolas PERRON about 11 years ago

Updated by Jonathan CLARKE about 11 years ago

Updated by Nicolas PERRON about 11 years ago

Updated by Nicolas PERRON about 11 years ago

Updated by Nicolas PERRON about 11 years ago

Updated by Benoît PECCATTE over 9 years ago