Bug #4109: /etc/cron.d/rudder-agent is not installed on Debian/Ubuntu - Rudder - Issue Tracker

Actions

Copy link

Bug #4109

closed

/etc/cron.d/rudder-agent is not installed on Debian/Ubuntu

Added by Vincent MEMBRÉ about 11 years ago. Updated almost 10 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Packaging

Target version:

2.6.9

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The new cron file used for 2.8 is not added when upgrading to Rudder 2.8 is not created (was upgrading from Rudder 2.4)

I thnik the file is not handled on installation by the packaging.

Line when upgrading is:

grep: /etc/cron.d/rudder-agent: No such file or directory

corresponding to line 101 in debian postinst:

CHECK_RUDDER_AGENT_CRON=`grep "/opt/rudder/bin/check-rudder-agent" /etc/cron.d/rudder-agent | wc -l`

Debian base nodes ill don't get advantage from that cron file

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

I also receive mail on my VM with this content:

From root@vagrant-debian-squeeze-64.vagrantup.com Mon Oct 28 17:15:01 2013
Return-path: <root@vagrant-debian-squeeze-64.vagrantup.com>
Envelope-to: root@vagrant-debian-squeeze-64.vagrantup.com
Delivery-date: Mon, 28 Oct 2013 17:15:01 +0100
Received: from root by node2.rudder.local with local (Exim 4.72)
        (envelope-from <root@vagrant-debian-squeeze-64.vagrantup.com>)
        id 1VapT3-0004Hv-8x
        for root@vagrant-debian-squeeze-64.vagrantup.com; Mon, 28 Oct 2013 17:15:01 +0100
Date: Mon, 28 Oct 2013 17:15:01 +0100
Message-Id: <E1VapT3-0004Hv-8x@node2.rudder.local>
From: root@vagrant-debian-squeeze-64.vagrantup.com (Cron Daemon)
To: root@vagrant-debian-squeeze-64.vagrantup.com
Subject: Cron <root@node2> /opt/rudder/bin/check-rudder-agent (failed)
Content-Type: text/plain; charset=UTF-8
X-Cron-Env: <SHELL=/bin/sh>
X-Cron-Env: <HOME=/root>
X-Cron-Env: <PATH=/usr/bin:/bin>
X-Cron-Env: <LOGNAME=root>

ls: cannot access /var/backups/rudder/rudder-agent.cron-*: No such file or directory
WARNING: The file /etc/cron.d/rudder-agent does not exist. The lastest backup () will be recovered...

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Status changed from New to 8

ls: cannot access /var/backups/rudder/rudder-agent.cron-*: No such file or directory
WARNING: The file /etc/cron.d/rudder-agent does not exist. The lastest backup () will be recovered...

This is definitely a bug in check-rudder-agent. We should not display errors about No such file, and we should not say we're recovering from a non-existant file.

However, there is something else going on here - after upgrading to 2.8, the /etc/cron.d/rudder-agent should definitely exist.

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Subject changed from When agent installed/updated to 2.8 on Debian "/etc/cron.d/rudder-agent" is missing to /etc/cron.d/rudder-agent is not installed.
Status changed from 8 to In progress
Assignee changed from Matthieu CERDA to Vincent MEMBRÉ
Target version changed from 2.8.0~rc2 to 2.6.9

It also happens on install and in all version > 2.6. fixing this immediatly.

It was not installed because dh_installcron takes files name "package.cron.*" not "package.cron".

We need to change the makefile in rudder-agent.

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE
Pull Request set to https://github.com/Normation/rudder-packages/pull/172

Pull request here: https://github.com/Normation/rudder-packages/pull/172

See dh_installcron man page : http://www.tin.org/bin/man.cgi?section=1&topic=dh_installcron

I just changed the name of the file when copied to "debian" directory, so the spec file can still use file rudder-agent.cron in the root directory.

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Status changed from Pending technical review to Discussion
Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ

Vincent MEMBRÉ wrote:

It also happens on install and in all version > 2.6. fixing this immediatly.

It was not installed because dh_installcron takes files name "package.cron.*" not "package.cron".

We need to change the makefile in rudder-agent.

When was this bug introduced? How long has it been since we didn't install the cron file?

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

we start using dh_installcron here: http://www.rudder-project.org/redmine/issues/3204

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Status changed from Discussion to Pending technical review

Actions

Copy link

Updated by Jonathan CLARKE about 11 years ago

Status changed from Pending technical review to Discussion

Vincent MEMBRÉ wrote:

we start using dh_installcron here: http://www.rudder-project.org/redmine/issues/3204

Wow, so it never actually installed the cron file on Debian... Oops... Fortunately, the cron file is installed by CFEngine minutes after the initial installation.

Actions

Copy link

#10