Project

General

Profile

Actions
Copy link

Bug #4111

closed

Inventory is never made due to the use of a wrong function ("isfile") in the promises

Added by Vincent MEMBRÉ about 11 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Jonathan CLARKE
Category:
Techniques
Target version:
2.4.12
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When installing / upgrading rudder agent to 2.8.0~rc1 we get an error

2013-10-28T17:46:35+0100   notice: Server is starting...
rudder-agent[12210]: [OK] CFEngine Community cf-serverd started after 1 seconds
rudder-agent[12211]: [INFO] Launching CFEngine Community cf-execd...
/var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf:100:122: error: Unknown function
      "rudder_inventory_cpuid_tool_present"    expression => isfile("\"${g.rudder_dependencies}\cpuid-windows-V1.0.vbs\"");
                                                                                                                         ^
/var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf:102:112: error: Unknown function
      "rudder_inventory_userlist_tool_present" expression => isfile("\"${g.rudder_dependencies}\userlist.bat\"");
                                                                                                               ^
/var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf:106:115: error: Unknown function
      "rudder_inventory_cpuid_tool_present"    expression => isfile("${g.rudder_dependencies}/cpuid-linux-V1.0.sh");
                                                                                                                  ^
2013-10-28T17:46:37+0100    error: Syntax errors were found in policy files included from the main policy
2013-10-28T17:46:37+0100    error: Policy failed validation with command '"/var/rudder/cfengine-community/bin/cf-promises" -c "/var/rudder/cfengine-community/inputs/promises.cf"'
2013-10-28T17:46:37+0100    error: CFEngine was not able to get confirmation of promises from cf-promises, so going to failsafe

Related issues 1 (0 open — 1 closed)

Related to Rudder - Bug #3854: The first inventory made display disturbing error messages about CPUReleasedJonathan CLARKE2013-08-20Actions
Actions
Copy link
 #1

Updated by Matthieu CERDA about 11 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 0 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/237

PR available.

Actions
Copy link
 #2

Updated by Jonathan CLARKE about 11 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

This looks pretty bad, indeed! How come it doesn't apply to anything pre-2.8?

Actions
Copy link
 #3

Updated by Matthieu CERDA about 11 years ago

  • Status changed from Discussion to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • Pull Request changed from https://github.com/Normation/rudder-techniques/pull/237 to https://github.com/Normation/rudder-techniques/pull/238

Damn right. PR updated !!!

Actions
Copy link
 #4

Updated by Jonathan CLARKE about 11 years ago

  • Status changed from Pending technical review to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

This looks pretty serious if it applied to 2.4... But I know that 2.4 used to work... So I don't see how this is possible. What commit introduced these errors, and what is the related ticket?

Actions
Copy link
 #5

Updated by Matthieu CERDA about 11 years ago

  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ about 11 years ago

  • Assignee changed from Jonathan CLARKE to Matthieu CERDA

It affects our 2.4 (2.6 2.7 too) nightlies, not our latest release.

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ about 11 years ago

  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
Actions
Copy link
 #8

Updated by Jonathan CLARKE about 11 years ago

Vincent MEMBRÉ wrote:

It affects our 2.4 (2.6 2.7 too) nightlies, not our latest release.

Phew, that's OK then! Thanks for clarifying :)

Actions
Copy link
 #9

Updated by Matthieu CERDA about 11 years ago

  • Status changed from Discussion to Pending release

Applied in changeset commit:ceb8aed50e75677986c7d529c14c13f96bfc2c68.

Actions
Copy link
 #10

Updated by Jonathan CLARKE about 11 years ago

Applied in changeset commit:ccee26d7156482d75748eacac38611d1a3ef74fd.

Actions
Copy link
 #11

Updated by Vincent MEMBRÉ about 11 years ago

  • Subject changed from Initial promises are not valid in 2.8; function "isfile" does not exist to Inventory Technique is not valid: "isfile" function does not exist
  • Target version changed from 2.8.0~rc2 to 2.4.12
Actions
Copy link
 #12

Updated by Nicolas PERRON about 11 years ago

  • Subject changed from Inventory Technique is not valid: "isfile" function does not exist to Inventory is never made due to th use of a wrong function ("isfile") in the promises
Actions
Copy link
 #13

Updated by Nicolas PERRON about 11 years ago

  • Subject changed from Inventory is never made due to th use of a wrong function ("isfile") in the promises to Inventory is never made due to the use of a wrong function ("isfile") in the promises
Actions
Copy link
 #14

Updated by Nicolas PERRON about 11 years ago

Introduced by #3854

Actions
Copy link
 #15

Updated by Nicolas PERRON about 11 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.4.12 which was released today.
Check out:

Actions
Copy link
 #16

Updated by Benoît PECCATTE almost 10 years ago

  • Project changed from 24 to Rudder
  • Category changed from Techniques to Techniques
Actions
Copy link

Also available in: Atom PDF