Bug #4132: slapd is not always restarted on upgrading, leading to missing schema update - Rudder - Issue Tracker

Actions

Copy link

Bug #4132

closed

slapd is not always restarted on upgrading, leading to missing schema update

Added by Vincent MEMBRÉ about 11 years ago. Updated over 9 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Jonathan CLARKE

Category:

Packaging

Target version:

2.4.12

Pull Request:

https://github.com/Normation/rudder-p...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

After upgrading Rudder server on rpm based systems, a warning is displayed:

********************************************************************************
rudder-webapp has been upgraded, but for the upgrade to take effect, please
restart the jetty application server as follows:
# /sbin/service jetty restart
********************************************************************************

But restarting it may cause some errors: rudder ldap schema is not updated

Following the rpm spec file, it should have been but it's clearly not.

restart slapd / or rudder-server-root fix the issue

A solution can be to change the warning to

/etc/init.d/rudder-server-root restart

so all our service will be restarted

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

slapd is not restarted on rpm when upgrading to 2.8

here the extract on sles11 :

Retrieving package rudder-inventory-ldap-1398866025:2.8.0.rc2-1.SLES.11.x86_64 (2/8), 2.7 MiB (12.4 MiB unpacked)
Retrieving: rudder-inventory-ldap-2.8.0.rc2-1.SLES.11.x86_64.rpm [done]
Installing: rudder-inventory-ldap-1398866025:2.8.0.rc2-1.SLES.11 [done]
Additional rpm output:
INFO: Setting slapd as a boot service... Done
INFO: Reloading syslogd...  Done
INFO: Starting slapd... Done

And here the same upgrade with an ubuntu 12.10:

Setting up rudder-inventory-ldap (2.8.0~rc2-quantal0) ...
INFO: Restarting syslogd... Done
INFO: OpenLDAP indexes are not up to date, reindexing... Done.
slapd[13049]: [INFO] Using /etc/default/slapd for configuration
slapd[13054]: [INFO] Halting OpenLDAP...
slapd[13058]: [OK] OpenLDAP stopped after 1 seconds
slapd[13059]: [INFO] Launching OpenLDAP database backup...
slapd[13076]: [OK] data save in /var/rudder/ldap/backup/openldap-data-20131106102018.ldif
slapd[13078]: [INFO] Halting OpenLDAP replication...
slapd[13079]: [INFO] no replica found in configuration, aborting stopping slurpd
slapd[13080]: [INFO] Launching OpenLDAP configuration test...
slapd[13082]: [OK] OpenLDAP configuration test successful
slapd[13083]: [INFO] Launching OpenLDAP replication...
slapd[13084]: [INFO] no replica found in configuration, aborting lauching slurpd
slapd[13085]: [INFO] no db_recover done
slapd[13086]: [INFO] Launching OpenLDAP...
slapd[13087]: [OK] file descriptor limit set to 1024
slapd[13094]: [OK] OpenLDAP started on port 389 and 636
Setting up rudder-jetty (2.8.0~rc2-quantal0) ...

It was both an upgrade from 2.7.5

Indexes needs to be updated in Ubuntu and Sles don't find it needs.

A solution may be to force restart at the end of spec file (a start is made, but it does nothing if slapd is still running ..)

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Status changed from New to In progress

Actions

Copy link

Updated by Vincent MEMBRÉ about 11 years ago

Subject changed from Upgrading rudder-webpp on rpm based system needs to restart slapd too to slapd is not always restarted on upgrading, leading to missing schema update
Target version changed from 2.6.9 to 2.4.12

In fact slapd may not be restarted even if schema has changed, on debian by luck, indexes have changed so slapd is restarted, but if it was not the case the bug would occurs too.

We need to always restart slapd at the end of rudder-inventory-ldap this occurs too in 2.4

A better version would be to prevent swapping (slapd may be restarted several times during upgrade. and this should be done once but that for a next version

Actions

Copy link