Bug #4155: Commands to check and restart cron daemon on Fedora are not correct - Rudder - Issue Tracker

Actions

Copy link

Bug #4155

closed

Commands to check and restart cron daemon on Fedora are not correct

Added by Christophe Nowicki about 11 years ago. Updated over 10 years ago.

Status:

Released

Priority:

Assignee:

Matthieu CERDA

Category:

System techniques

Target version:

2.6.11

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

Hi,

Fedora is using SystemD and other GNU/Linux distributions are adopting this init system.
Could you fix the check_cron_daemon in :

https://github.com/Normation/rudder-techniques/blob/master/initial-promises/node-server/promises.cf

Current version is :

  vars:

    redhat::
      "cron_bin" string => "crond$";
      "cron_restartcmd" string => "/etc/init.d/crond restart";

    ubuntu::
      "cron_bin" string => "cron$";
      "cron_restartcmd" string => "/etc/init.d/cron restart";

    !(redhat|ubuntu)::
      "cron_bin" string => "/usr/sbin/cron$";
      "cron_restartcmd" string => "/etc/init.d/cron restart";

Could you add fedora and use service instead of '/etc/init.d/*'

  vars:

    redhat::
      "cron_bin" string => "crond$";
      "cron_restartcmd" string => "/etc/init.d/crond restart";

    fedora::
      "cron_bin" string => "crond$";
      "cron_restartcmd" string => "/bin/systemctl restart crond.service"";

    ubuntu::
      "cron_bin" string => "cron$";
      "cron_restartcmd" string => "/etc/init.d/cron restart";

    !(redhat|ubuntu|fedora)::
      "cron_bin" string => "/usr/sbin/cron$";
      "cron_restartcmd" string => "service cron restart";

Best Regards,

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by François ARMAND about 11 years ago

Assignee set to Matthieu CERDA

Thanks for reporting!
Matthieu, I believe you're the one for that one.

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Category set to System techniques
Status changed from New to In progress
Priority changed from N/A to 2
Target version set to 2.9.3

On it.

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Target version changed from 2.9.3 to 2.6.11

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Matthieu CERDA to Jonathan CLARKE
% Done changed from 0 to 100
Pull Request set to https://github.com/Normation/rudder-techniques/pull/277

PR ready

Actions

Copy link

Updated by Matthieu CERDA almost 11 years ago

Status changed from Pending technical review to Pending release

Applied in changeset policy-templates:commit:0a15d6ba5ad447e807670b59faef062d1f46ecf0.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Applied in changeset policy-templates:commit:397f69218c8ed2ce6ba8225e1299deba8447538d.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Thanks for this, it has been merged.

However, it made me realise that the fix for #4156 is wrong - it uses hard class "Fedora" instead of "fedora", so won't work. I'll reopen and assign to you, Matthieu.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Status changed from Pending release to 8
Assignee changed from Jonathan CLARKE to Matthieu CERDA

While reviewing the fix for #4155, I realised that the fix committed here won't work: it uses hard class "Fedora" instead of "fedora", so won't work.

Reopening. Matthieu, please adjust this.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Status changed from 8 to Pending technical review

Jonathan CLARKE wrote:

While reviewing the fix for #4155, I realised that the fix committed here won't work: it uses hard class "Fedora" instead of "fedora", so won't work.

Reopening. Matthieu, please adjust this.

Whoops, I reopened the wrong ticket. Closing again, sorry for the noise.

Actions

Copy link

#10