Project

General

Profile

Actions
Copy link

Bug #4156

closed

Command to restart rsyslog is not correct on Fedora

Added by Christophe Nowicki over 9 years ago. Updated about 9 years ago.

Status:
Released
Priority:
2
Assignee:
Jonathan CLARKE
Category:
System techniques
Target version:
2.6.11
Pull Request:
https://github.com/Normation/rudder-t...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Regression:

Description

The check_rsyslog_version does not restart the rsyslog daemon on Fedora.

You should change :

 bundle agent check_rsyslog_version {
  vars:
    SuSE::
      "syslog_restart_cmd" string => "/etc/init.d/syslog restart";

    !SuSE::
      "syslog_restart_cmd" string => "/etc/init.d/rsyslog restart";

Into :

 bundle agent check_rsyslog_version {
  vars:
    SuSE::
      "syslog_restart_cmd" string => "/etc/init.d/syslog restart";

    Fedora::
      "syslog_restart_cmd" string => "/bin/systemctl  restart rsyslog";

    !(SuSE|Fedora)::
      "syslog_restart_cmd" string => "/etc/init.d/rsyslog restart";

Best Regards,

Actions
Copy link
 #1

Updated by Nicolas CHARLES over 9 years ago

  • Category set to System techniques
  • Assignee set to Nicolas CHARLES
  • Priority changed from N/A to 2
  • Target version set to 2.4.12

Thank you Christophe !
I'll implement the fix asap

Actions
Copy link
 #2

Updated by Matthieu CERDA over 9 years ago

I'm pretty sure this is not the only place where we need to implement this kind of change, we should open a second issue to track systemd compatibility.

Actions
Copy link
 #3

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Nicolas CHARLES to Jonathan CLARKE
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/241
Actions
Copy link
 #4

Updated by Nicolas CHARLES over 9 years ago

Christophe, thank you for you contribution.

Since you proposed a modification of code, could you sign the Contributor Licence Agreement (CLA or CCLA) as described in this page:
http://www.rudder-project.org/foswiki/Development/HowToContribute

It would help keep track of your original creation, state that your contribution is voluntary, and that we will correctly credit you in changelog etc.

Thank you !

Actions
Copy link
 #5

Updated by Nicolas PERRON over 9 years ago

  • Target version changed from 2.4.12 to 2.4.13
Actions
Copy link
 #6

Updated by Nicolas CHARLES over 9 years ago

Hi Christophe,

Thank you again for your contribution. Sorry to nag you, but did you see my message about the Contributor License Agreement ?

Thank you

Actions
Copy link
 #7

Updated by Nicolas CHARLES over 9 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100

Applied in changeset policy-templates:commit:f812861d785ee55011609cc1bcdbbfa90c82f8a5.

Actions
Copy link
 #8

Updated by Jonathan CLARKE over 9 years ago

Applied in changeset policy-templates:commit:50972c8d333935a324ee303bb7b8d416488981f3.

Actions
Copy link
 #9

Updated by Vincent MEMBRÉ over 9 years ago

  • Target version changed from 2.4.13 to 2.6.10

Since we will not make any more releases of 2.4 version, moving all those issues to 2.6

Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 9 years ago

  • Subject changed from check_rsyslog_version on Fedora to command to restart rsyslog is not correct on Fedora
Actions
Copy link
 #11

Updated by Vincent MEMBRÉ over 9 years ago

  • Subject changed from command to restart rsyslog is not correct on Fedora to Command to restart rsyslog is not correct on Fedora
Actions
Copy link
 #12

Updated by Vincent MEMBRÉ over 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.10 which was released today.
Check out:

Actions
Copy link
 #13

Updated by Jonathan CLARKE over 9 years ago

  • Status changed from Released to Discussion
  • Assignee changed from Jonathan CLARKE to Matthieu CERDA
  • Target version changed from 2.6.10 to 2.6.11

While reviewing the fix for #4155, I realised that the fix committed here won't work: it uses hard class "Fedora" instead of "fedora", so won't work.

Reopening. Matthieu, please adjust this.

Actions
Copy link
 #14

Updated by Matthieu CERDA over 9 years ago

  • Status changed from Discussion to In progress
  • % Done changed from 100 to 80
  • Pull Request deleted (https://github.com/Normation/rudder-techniques/pull/241)
Actions
Copy link
 #15

Updated by Matthieu CERDA over 9 years ago

  • Status changed from In progress to Pending technical review
  • Assignee changed from Matthieu CERDA to Jonathan CLARKE
  • % Done changed from 80 to 100
  • Pull Request set to https://github.com/Normation/rudder-techniques/pull/278

(very simple) PR ready :)

Actions
Copy link
 #16

Updated by Matthieu CERDA over 9 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset policy-templates:commit:9e68153dbcbacd016989db120e0fbb625b98b441.

Actions
Copy link
 #17

Updated by Jonathan CLARKE over 9 years ago

Applied in changeset policy-templates:commit:b26bc51ca0789986374db0fc38a6f49812a1b2be.

Actions
Copy link
 #18

Updated by Vincent MEMBRÉ about 9 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.6.11, which was released today.
Check out:

Actions
Copy link

Also available in: Atom PDF