Bug #4282
closedUser story #4293: Migrating from a Technique version to another one in a Directive is long and painful
Directive migration doesn't handle default values
Description
MOTD configuration technique forces useless option
The form contains some errors, please correct them. 'Where should this text be added in the MOTD' field must not be empty
It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".
Updated by Dennis Cabooter about 11 years ago
I fogot to say I'm talking about version 3.0 of the MOTD technique.
Updated by Matthieu CERDA about 11 years ago
- Category set to Techniques
- Status changed from New to 8
- Assignee set to Matthieu CERDA
- Priority changed from N/A to 4
- Target version set to 2.6.10
Qualifying this. Thanks for reporting Dennis :)
Updated by Jonathan CLARKE almost 11 years ago
- Status changed from 8 to Discussion
- Assignee changed from Matthieu CERDA to Dennis Cabooter
Dennis Cabooter wrote:
MOTD configuration technique forces useless option
[...]
It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".
I am confused. This option is a boolean option (two choices), and there is a default value. How did you manage to have no values selected?
Did this happen while migrating from an older version, by any chance?
Updated by Jonathan CLARKE almost 11 years ago
- Assignee changed from Dennis Cabooter to François ARMAND
Jonathan CLARKE wrote:
Dennis Cabooter wrote:
MOTD configuration technique forces useless option
[...]
It's useless here to tell if the text should be added at the beginning or end, since I already set "Enforce this MOTD only" to "Yes".
I am confused. This option is a boolean option (two choices), and there is a default value. How did you manage to have no values selected?
Did this happen while migrating from an older version, by any chance?
Aha, I just tested myself (sorry, should have done that first, before asking you Dennis!) and this does indeed happen when migrating from an older version. In that case, the default value is not applied!
In my opinion, this is therefore not a Technique bug (we can't make a SELECT1 variable non mandatory, this doesn't make any sense).
François, over to you to decide how to handle this. I think we should change Directive version migation to honour default values, but highlight which variables are new to the user in the form, so it's easy for him/her to validate the default values.
Updated by Vincent MEMBRÉ almost 11 years ago
- Target version changed from 2.6.10 to 2.6.11
Updated by Jonathan CLARKE almost 11 years ago
- Subject changed from MOTD configuration technique forces useless option to Directive migration doesn't handle default values
- Category changed from Techniques to Web - Config management
- Priority changed from 4 to 2
Updating the subject to clarify.
François, what's your opinion here?
Updated by Vincent MEMBRÉ almost 11 years ago
- Target version changed from 2.6.11 to 2.6.12
Updated by Vincent MEMBRÉ almost 11 years ago
- Target version changed from 2.6.12 to 2.6.13
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.6.13 to 2.6.14
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.6.14 to 2.6.16
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.6.16 to 2.6.17
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.6.17 to 2.6.18
Updated by Matthieu CERDA about 10 years ago
- Target version changed from 2.6.18 to 2.6.19
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.6.19 to 2.6.20
Updated by François ARMAND almost 10 years ago
- Target version changed from 2.6.20 to 2.10.9
Jonathan CLARKE wrote:
François, over to you to decide how to handle this. I think we should change Directive version migation to honour default values, but highlight which variables are new to the user in the form, so it's easy for him/her to validate the default values.
Yes, it's the only sane thing to do.
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.9 to 2.10.10
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.10 to 2.10.11
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.11 to 2.10.12
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.12 to 2.10.13
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.13 to 2.10.14
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.14 to 2.10.15
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.15 to 2.10.16
Updated by Nicolas CHARLES over 9 years ago
- Target version changed from 2.10.16 to 2.11.13
I also agree that during a version migration we should get default values for new values
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.11.13 to 2.11.14
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.14 to 2.11.15
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.15 to 2.11.16
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.16 to 2.11.17
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.11.17 to 2.11.18
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.11.18 to 2.11.19
Updated by Vincent MEMBRÉ almost 9 years ago
- Related to Bug #7871: Directive version migration should set default values if present added
Updated by Vincent MEMBRÉ almost 9 years ago
- Related to deleted (Bug #7871: Directive version migration should set default values if present)
Updated by Vincent MEMBRÉ almost 9 years ago
- Has duplicate Bug #7871: Directive version migration should set default values if present added
Updated by Jonathan CLARKE almost 9 years ago
- Translation missing: en.field_tag_list set to Quick and important
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from Discussion to In progress
- Assignee changed from François ARMAND to Vincent MEMBRÉ
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/1044
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from Pending technical review to In progress
- Assignee changed from François ARMAND to Vincent MEMBRÉ
Updated by Vincent MEMBRÉ almost 9 years ago
- Pull Request deleted (
https://github.com/Normation/rudder/pull/1044)
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from In progress to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/1045
Updated by Vincent MEMBRÉ almost 9 years ago
- Pull Request deleted (
https://github.com/Normation/rudder/pull/1045)
Updated by Vincent MEMBRÉ almost 9 years ago
- Pull Request set to https://github.com/Normation/rudder/pull/1046
Updated by Vincent MEMBRÉ almost 9 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset rudder|fcc56571e8fadce29b02da693fea288a7ac6961d.
Updated by Vincent MEMBRÉ over 8 years ago
- Status changed from Pending release to Released