https://issues.rudder.io/https://issues.rudder.io/themes/rudder7/favicon/favicon.ico?17096450182014-01-03T08:49:00ZIssue TrackerRudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=233962014-01-03T08:49:00ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Category</strong> set to <i>26</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>8</i></li><li><strong>Assignee</strong> set to <i>Matthieu CERDA</i></li><li><strong>Priority</strong> changed from <i>N/A</i> to <i>1</i></li><li><strong>Target version</strong> set to <i>2.6.10</i></li></ul><p>Wow, I love the idea, the proposed fix would be much more flexible than having to wait for a CFEngine patch to be tested and validated...</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=233972014-01-03T08:58:21ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>Alex, I will let Matthieu handle the ticket, but I just would like to thank you for such a detailled, nice, thoughtfull bug report - the kind all open source project love to have. So thank you, it's a marvelous gift for us!</p>
<p>On a side note, would you please sign the CLA so that we can merge you patch as is ? It's a couple of click here: <a class="external" href="https://secure.echosign.com/public/hostedForm?formid=ECPMWD7B3BU3H">https://secure.echosign.com/public/hostedForm?formid=ECPMWD7B3BU3H</a><br />(there is explanation about the CLA <em>raison d'être</em> here: <a class="external" href="http://www.rudder-project.org/foswiki/Development/HowToContribute">http://www.rudder-project.org/foswiki/Development/HowToContribute</a>).</p>
<p>Thanks again for that ticket.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234182014-01-03T14:41:27ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Status</strong> changed from <i>8</i> to <i>Pending technical review</i></li><li><strong>Assignee</strong> changed from <i>Matthieu CERDA</i> to <i>Jonathan CLARKE</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Pull Request</strong> set to <i>https://github.com/Normation/rudder-packages/pull/204</i></li></ul><p>PR ready to review !</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234302014-01-03T18:22:31ZAlex Tkachenkoalex.sysadm@gmail.com
<ul></ul><p>I have signed the CLA.</p>
<p>As for the review - I take it there are no actions on my part are expected. However:</p>
<p>- the patch was submitted against one file, but there are two identical files, one under /opt/rudder/share/fusioninventory/lib/FusionInventory and another under /opt/rudder/lib/perl5/FusionInventory - I am not sure why the share is actually working while the other does not, as /opt/rudder/bin/run-inventory includes /opt/rudder/lib/perl5 earlier - anyway, you may want to apply the fix to both;</p>
<p>- does making the target v2.6.10 cover v2.8.x too? How long will it take to make it into actual RPMs? I thought I could do the rebuild myself, but it looks like the source rpms provided at the download location are not enough - is there a build setup description available anywhere?</p>
<p>- in theory, the proper place to fix this would be in addField, but as this is just a temp workaround (until cfe 3.6 which is due in March, I hope) it may be OK. We just need to remember to remove it in the future.</p>
<p>The patch was garbled a bit during the submission, and I am glad you have noticed that.</p>
<p>Thank you so much for the agile response!</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234402014-01-07T09:45:13ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>Alex Tkachenko wrote:</p>
<blockquote>
<p>I have signed the CLA.</p>
</blockquote>
<p>We saw that, thanks!</p>
<p>Just some more info on that part:</p>
<blockquote>
<p>- does making the target v2.6.10 cover v2.8.x too? How long will it take to make it into actual RPMs?</p>
</blockquote>
<p>Yes, making the target 2.6 will cover all (supported) version to the most recent. We have as policy to correct bug in the oldest supported version they appeared into, and then make the correction pop-up to newer versions.</p>
<p>As soon as the pull request is validated and merged, the code will go into our continuous integration infrastructure, and then, it should be present in the next nightly packages, and then in the next minor release (bug fix) of each supported version.</p>
<p>Now, Jon, it's up to you with the technical review.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234422014-01-07T13:03:09ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>I agree with this fix as a temporary workaround - it is short and simple, can't really go wrong here. I will merge it in 2.6 branch, and it will be merged up into 2.7, 2.8 and 2.9, and be available in tomorrow's nightly builds of rudder-agent. Then, it will be in the next minor release on each of these branches.</p>
<p>However, I think that we can implement a cleaner workaround for the next major version. Currently, the only reason we have CFEngine editing the XML inventory file is to <strong>add</strong> some lines. How about we have CFEngine spit these lines out into a separate file, then just concatenate them together (we may need to be clever to get them in the right place in the XML, but tail/head/cat should manage just fine). This way, we no longer have any edit_line on this file in CFEngine, and the 4096 char limit is no longer a problem!</p>
<p>What do you guys think?</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234432014-01-07T13:03:26ZMatthieu CERDAmatthieu.cerda@normation.com
<ul><li><strong>Status</strong> changed from <i>Pending technical review</i> to <i>Pending release</i></li></ul><p>Applied in changeset packages:commit:92c011866e562c97ba8682fd367280581035da0b.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234442014-01-07T13:03:26ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>Applied in changeset packages:commit:a2b7f7b5d332bd257c11dfe666f2930ee70a1965.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234452014-01-07T13:05:46ZMatthieu CERDAmatthieu.cerda@normation.com
<ul></ul><p>Looks like a good idea, we have to make sure that this doesn't break anything since we add quite a bunch of info, os-specifically.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234462014-01-07T13:10:21ZFrançois ARMANDfrancois.armand@rudder.io
<ul></ul><p>Jonathan CLARKE wrote:</p>
<blockquote>
<p>I agree with this fix as a temporary workaround - it is short and simple, can't really go wrong here. I will merge it in 2.6 branch, and it will be merged up into 2.7, 2.8 and 2.9, and be available in tomorrow's nightly builds of rudder-agent. Then, it will be in the next minor release on each of these branches.</p>
<p>However, I think that we can implement a cleaner workaround for the next major version. Currently, the only reason we have CFEngine editing the XML inventory file is to <strong>add</strong> some lines. How about we have CFEngine spit these lines out into a separate file, then just concatenate them together (we may need to be clever to get them in the right place in the XML, but tail/head/cat should manage just fine). This way, we no longer have any edit_line on this file in CFEngine, and the 4096 char limit is no longer a problem!</p>
<p>What do you guys think?</p>
</blockquote>
<p>That seems far clearer, and even more futur-proof: it will be easier to integrate a Fusion-Rudder plugin if we already manage Rudder specific things without CFEngine (or at least, with the minimum implication of CFEngine in the middle).</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234552014-01-07T22:14:24ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>François ARMAND wrote:</p>
<blockquote>
<p>That seems far clearer, and even more futur-proof: it will be easier to integrate a Fusion-Rudder plugin if we already manage Rudder specific things without CFEngine (or at least, with the minimum implication of CFEngine in the middle).</p>
</blockquote>
<p>Actually that's a good point - we already contributed a lot of work upstream to FusionInventory for this (see <a class="external" href="http://forge.fusioninventory.org/issues/1689#change-6905">http://forge.fusioninventory.org/issues/1689#change-6905</a> and <a class="external" href="https://www.rudder-project.org/foswiki/Development/FusionInventory">https://www.rudder-project.org/foswiki/Development/FusionInventory</a>). It should be in the latest releases. So, just upgrading our FusionInventory, and fixing rudder-inventory-endpoint to handle the new fields would do this.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=234572014-01-07T22:21:02ZJonathan CLARKEjonathan.clarke@normation.com
<ul></ul><p>We can follow up on this in <a class="issue tracker-2 status-6 priority-16 priority-default closed parent" title="User story: FusionInventory integration to Rudder (Rejected)" href="https://issues.rudder.io/issues/2479">#2479</a>.</p> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=237672014-01-15T16:03:37ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Subject</strong> changed from <i>A bug in cfengine prevents agent hosts from being added to the server</i> to <i>Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEngine</i></li></ul> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=238322014-01-16T15:35:28ZVincent MEMBRÉvme@rudder.io
<ul><li><strong>Status</strong> changed from <i>Pending release</i> to <i>Released</i></li></ul><p>This bug has been fixed in Rudder 2.6.10 which was released today.<br />Check out: </p>
<ul>
<li>The release announcement: <a class="external" href="http://www.rudder-project.org/pipermail/rudder-announce/2014-January/000070.html">http://www.rudder-project.org/pipermail/rudder-announce/2014-January/000070.html</a></li>
<li>The full ChangeLog: <a class="external" href="http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26">http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog26</a></li>
<li>Download information: <a class="external" href="https://www.rudder-project.org/site/get-rudder/downloads/">https://www.rudder-project.org/site/get-rudder/downloads/</a></li>
</ul> Rudder - Bug #4314: Inventories containing very long (> 4096) process name cannot be send to rudder server via CFEnginehttps://issues.rudder.io/issues/4314?journal_id=375222015-03-11T10:56:36ZBenoît PECCATTEbenoit.peccatte@rudder.io
<ul><li><strong>Category</strong> changed from <i>26</i> to <i>Web - Nodes & inventories</i></li></ul>