User story #4330: Rule names should be only unique by categories, not globally - Rudder - Issue Tracker

Actions

Copy link

User story #4330

open

Rule names should be only unique by categories, not globally

Added by Dennis Cabooter almost 11 years ago. Updated 2 months ago.

Status:

New

Priority:

N/A

Assignee:

Category:

Web - Config management

Target version:

Ideas (not version specific)

Pull Request:

UX impact:

Suggestion strength:

User visibility:

Effort required:

Name check:

Fix check:

Regression:

Description

In 2.8 I had those Rules:

CentOS desktops: files
CentOS desktops: packages
Ubuntu servers: files
Ubuntu servers: packages

In 2.9 I tried To split those Rules into two categories (Ubuntu/Centos):

CentOS desktops
- files
- packages
Ubuntu servers
- files
- packages

Unfortunatly that's not allowed.

In my humble opinion the rules names should change to ${category}.${rulename} instead of ${rulename}. You should check only if there is a rule with same name within the category.

Actions

Copy link

Updated by Dennis Cabooter almost 11 years ago

I forgot the <pre></pre> tags. Sorry for the inconvenience.

In 2.8 I had:

-
  - CentOS desktops: files
  - CentOS desktops: packages
  - Ubuntu servers: files
  - Ubuntu servers: packages

In 2.9 I tried:

- CentOS desktops
  - files
  - packages
- Ubuntu servers
  - files
  - packages

Unfortunatly that's not allowed.

In my humble opinion the rules names should change to ${category}.${rulename} instead of ${rulename}. You should check only if there is a rule with same name within the category.

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Description updated (diff)
Category set to Web - Config management
Assignee set to Vincent MEMBRÉ
Priority changed from N/A to 3

I edited the description:

So you were trying to have two Rules named files in different categories (Ubuntu and Centos).

As we kept the old behavior in Rule naming, this is not allowed, but you're right and I think that should be changed to Refuse only Rules with same name in the same category

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Description updated (diff)

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Target version changed from 2.9.2 to 2.9.3

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Target version changed from 2.9.3 to 2.9.4

Actions

Copy link

Updated by Dennis Cabooter over 10 years ago

Is this still going forward?

Actions

Copy link

Updated by François ARMAND over 10 years ago

Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

I don't thing we took a decision about that.

Assigning to Jon so that he can set his Product Owner eyes on it :)

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Assignee changed from Jonathan CLARKE to François ARMAND

I agree with Vincent, we should change this to allow only Rules with duplicated names so long as they are not in the same category.

Actions

Copy link

Updated by Vincent MEMBRÉ over 10 years ago

Target version changed from 2.9.4 to 2.9.5

Actions

Copy link

#10

Updated by Vincent MEMBRÉ over 10 years ago

Target version changed from 2.9.5 to 2.9.6

Actions

Copy link

#11

Updated by Jonathan CLARKE over 10 years ago

Target version changed from 2.9.6 to 2.9.7

Actions

Copy link

#12

Updated by Jonathan CLARKE over 10 years ago

Target version changed from 2.9.7 to 150

Actions

Copy link

#13

Updated by Vincent MEMBRÉ over 10 years ago

Target version changed from 150 to 2.10.4

Actions

Copy link

#14

Updated by Nicolas PERRON over 10 years ago

Target version changed from 2.10.4 to 2.10.5

Actions

Copy link

#15

Updated by Vincent MEMBRÉ about 10 years ago

Target version changed from 2.10.5 to 2.10.6

Actions

Copy link

#16

Updated by Dennis Cabooter about 10 years ago

Can someone look @ this again?

Actions

Copy link

#17

Updated by Matthieu CERDA about 10 years ago

Target version changed from 2.10.6 to 2.10.7

Actions

Copy link

#18

Updated by Vincent MEMBRÉ about 10 years ago

Target version changed from 2.10.7 to 2.10.8

Actions

Copy link

#19

Updated by François ARMAND almost 10 years ago

If I remember correctly, we chose to forbid rules with the same name application-wide to not have ambiguities in reports, when only the rule name is diplayed.

Actions

Copy link

#20