Bug #4347: Incorrect detection of empty password/name in 'userManagement' Technique when several user are to be managed - Rudder - Issue Tracker

Actions

Copy link

Bug #4347

closed

Incorrect detection of empty password/name in 'userManagement' Technique when several user are to be managed

Added by Nicolas CHARLES almost 11 years ago. Updated almost 11 years ago.

Status:

Released

Priority:

Assignee:

Jonathan CLARKE

Category:

Techniques

Target version:

2.6.10

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

The detection of empty fields relies only on "isvariable" to detect empty value. However, while it makes sense to use isvariable for empty value when only one empty value is set (due to implementation used in cf-clerk), when we have several values, even when empty, the values are there, but empty.
To have proper detection, we should use both isvariable (for only one value) and strcmp
Reported originaly by Alex Tkachenko in #4342

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nicolas CHARLES almost 11 years ago

Status changed from In progress to Pending technical review
Assignee changed from Nicolas CHARLES to Jonathan CLARKE
Pull Request set to https://github.com/Normation/rudder-techniques/pull/267

PR is there: https://github.com/Normation/rudder-techniques/pull/267

Actions

Copy link

Updated by Nicolas CHARLES almost 11 years ago

Status changed from Pending technical review to Pending release
% Done changed from 0 to 100

Applied in changeset policy-templates:commit:9cb3221b00a790990efbb8c67748fa30b16b8509.

Actions

Copy link

Updated by Jonathan CLARKE almost 11 years ago

Applied in changeset policy-templates:commit:392067450a63770708950686640f9df9857c622a.

Actions

Copy link

Updated by Vincent MEMBRÉ almost 11 years ago

Subject changed from Incorrect detection of empty password/name in usermanagement technique when several user are to be managed to Incorrect detection of empty password/name in 'userManagement' Technique when several user are to be managed

Actions

Copy link