Project

General

Profile

Actions
Copy link

Bug #4383

closed

When adding a Directive to a Rule from a newly created Directives screen, Change Request popup not displayed

Added by Jonathan CLARKE almost 11 years ago. Updated over 10 years ago.

Status:
Released
Priority:
3
Assignee:
Vincent MEMBRÉ
Category:
Web - Config management
Target version:
2.8.3
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I have Rudder 2.9.2 with Change Requests enabled. When I modify a Directive, and hit the "Target Rules" tab, and add a Rule, then click save, I see:
  1. A popup asking me if I'm sure I want to edit this Directive
  2. Another popup saying my changes were saved successfully
  3. By checking afterwards, a Change Request was created
What I expected to see:
  1. A popup saying "Workflows are enabled, your change has to be validated in a Change request" and asking me to type in a title and description
  2. Being redirected to the newly created Change Request
Actions
Copy link
 #1

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from 8 to Discussion
  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

I was not able to reproduce it on 3 different Rudder servers ...

Like you said, I clicked on a Directive, modify in "Target Rules" so a new Rule apply the Directive and save and I got the workflow popup and when validating I'm redirected to the change request page.

Do you have any more infos on how to reproduce it ?

Actions
Copy link
 #2

Updated by Jonathan CLARKE almost 11 years ago

Something that might be important: I had only just enabled Change Requests prior to this happening (no restart since).

Also, I had disabled the "Change message" feature.

I'm not sure, but I imagine one of these things will be the cause.

Actions
Copy link
 #3

Updated by Jonathan CLARKE almost 11 years ago

  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
Actions
Copy link
 #4

Updated by Vincent MEMBRÉ almost 11 years ago

  • Assignee changed from Vincent MEMBRÉ to Jonathan CLARKE

I enabled change request just before doing it too.

I tried when disabling change message, and was not able to reproduce either.

Actions
Copy link
 #5

Updated by Jonathan CLARKE almost 11 years ago

  • Subject changed from When adding a Directive to a Rule from Directives screen, Change Request popup not displayed to When adding a Directive to a Rule from a newly created Directives screen, Change Request popup not displayed
  • Status changed from Discussion to 8
  • Assignee changed from Jonathan CLARKE to Vincent MEMBRÉ
  • Priority changed from 2 to 3

Actually, I couldn't reproduce this either. After checking, the problem actually occurs like this:

  1. Create a new Directive and fill in any required parameters. Do not apply it to any target Rules. Save. No change request popup is displayed, but this is normal, since there aren't any for object creations.
  2. Then, without reloading or changing pages, go to the "Target Rules" tab, and add a Rule. Click save. Then, you see:
    • A popup asking me if I'm sure I want to edit this Directive
    • Another popup saying my changes were saved successfully
    • By checking afterwards, a Change Request was created

What I expected to see:

  • A popup saying "Workflows are enabled, your change has to be validated in a Change request" and asking me to type in a title and description
  • Being redirected to the newly created Change Request
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ almost 11 years ago

  • Target version changed from 2.9.3 to 2.8.3

THis is happening in 2.8 too!

Actions
Copy link
 #7

Updated by Vincent MEMBRÉ almost 11 years ago

  • Status changed from 8 to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Vincent MEMBRÉ almost 11 years ago

  • % Done changed from 100 to 0
  • Pull Request set to https://github.com/Normation/rudder/pull/430

The Directive form was believing workflow were disabled :(

Maybe we could authorize to not create change request if the Directive is not applied by any Rule (or in a pending change request)

I opened #4391 to track tht idea!

PR is here: https://github.com/Normation/rudder/pull/430

But magical powers of Nicolas Charles have already merged that pull request!

Actions
Copy link
 #10

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.8.3, which was released today.
Check out:

Actions
Copy link

Also available in: Atom PDF