Bug #4386
closedList node API : typo on "machyneType" (should be "machineType")
Description
A request on the list of node returns:
{"action":"listAcceptedNodes","result":"success","data":{"nodes":[{"id":"41affc17-e432-420c-8f64-b819e96c67fc","status":"accepted","hostname":"sles-11","osName":"Suse","osVersion":"11","machyneType":"Virtual"}
The machyneType is not that great :/
On which version should we correct it ? People may rely on this text already
Updated by Jonathan CLARKE over 10 years ago
- Subject changed from Typo dans list node API : machyneType to List node API : typo on "machyneType" (should be "machineType")
- Status changed from New to 8
- Assignee set to Vincent MEMBRÉ
This is terribly unfortunate.
We will have to create a new version of the API. It is unthinkable to change a key without incrementing the version.
Vincent, please fix this ASAP.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from 8 to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/465
Updated by François ARMAND over 10 years ago
There is no target version for that, should it go in 2.10 only ?
Updated by François ARMAND over 10 years ago
- Assignee changed from François ARMAND to Jonathan CLARKE
Updated by Jonathan CLARKE over 10 years ago
- Target version set to 2.10.0~beta1
François ARMAND wrote:
There is no target version for that, should it go in 2.10 only ?
Yes, I see no reason to impact released branches for a silly typo. It could so easily break existing scripts using "latest" version, it's not worth the risk.
Updated by Jonathan CLARKE over 10 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
Updated by François ARMAND over 10 years ago
- Assignee changed from François ARMAND to Jonathan CLARKE
- Target version deleted (
2.10.0~beta1)
Great!
Updated by François ARMAND over 10 years ago
- Assignee changed from Jonathan CLARKE to François ARMAND
Sorry, the assignee mod wasn't intended
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending technical review to Pending release
- % Done changed from 0 to 100
Applied in changeset 6b2b801a2c0e3686bae57077b3153e97322e6006.
Updated by Anonymous over 10 years ago
Applied in changeset adaede43b20fbd3414776a7431ed28aea4ff15de.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending release to Released
- Target version set to 2.10.0~beta1
Updated by François ARMAND almost 6 years ago
- Related to Bug #13795: Remove old "machyne type" api Rest typo since it should not be called anymore added