Project

General

Profile

Actions

Bug #4404

closed

The bundle _classes_copy.cf does not copy prefix from result classes

Added by Nicolas PERRON over 8 years ago. Updated 4 months ago.

Status:
Released
Priority:
N/A
Category:
Generic methods
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
0
Regression:

Description

The bundle _classes_copy.cf copy the suffix of a result class but not the prefix.

Example:

The use of _classes_copy() from a command_execution() bundle to a service_restart() bundle will result into:

command_execution result classes:
- 'promise_repaired_command_execution__etc_init_d_cron_restart'
- 'command_execution__etc_init_d_cron_restart_repaired'
- 'command_execution__etc_init_d_cron_restart_ok'
- 'command_execution__etc_init_d_cron_restart_reached'

service_restart result classes:
- 'service_restart_cron_repaired'
- 'service_restart_cron_ok'
- 'service_restart_cron_reached'

promise_repaired_service_restart_cron is missing from the new classes.

Actions #1

Updated by Nicolas PERRON over 8 years ago

  • Status changed from New to Pending technical review
  • Assignee set to Jonathan CLARKE
  • Target version set to 0.x
  • % Done changed from 0 to 100

Pull Request URL added: https://github.com/Normation/ncf/pull/33

I've also added an acceptance test which was missing...
Jon, could you review the PR please ?

Actions #2

Updated by Nicolas PERRON over 8 years ago

  • Status changed from Pending technical review to Pending release

Applied in changeset commit:9888e6b2d239126f23c13e6193b2a710d8e5564f.

Actions #3

Updated by Jonathan CLARKE over 8 years ago

Applied in changeset commit:a77390d162e6f22410d85e26fbd7d1ac0b0c38bd.

Actions #4

Updated by Vincent MEMBRÉ about 6 years ago

  • Status changed from Pending release to Released
Actions #5

Updated by Alexis Mousset 4 months ago

  • Target version changed from 0.x to ncf-0.x
  • Priority set to 0
Actions #6

Updated by Alexis Mousset 4 months ago

  • Project changed from 41 to Rudder
  • Category set to Generic methods
Actions

Also available in: Atom PDF