Bug #4557
closed
Rule compliance shows red when it should be yellow
Description
Rule compliance shows red when it should be yellow. A red compliance on a rule imply that something bad is going on. However, when I look at it, the worst status is repaired. I'm aware that if a file is repaired every run, most times something is wrong. I say most times, because in the motd technique I update last policy update data/time every run, so the file should be repaired every run and that's ok. If there is something wrong when something is repaired every run, for example if 2 directives edit the same file, people should get a warning in compliance details. Still red implies at least one error, while there isn't. I would propose to use the color of the worst status for rule compliances.
Updated by Matthieu CERDA over 10 years ago
- Status changed from New to 8
- Assignee set to François ARMAND
- Priority changed from N/A to 2
- Target version set to 2.6.12
Hm, it looks like I cannot help a lot here :) assigning to FAR for task dispatching !
Thanks for the report !
Updated by François ARMAND over 10 years ago
- Tracker changed from User story to Bug
- Project changed from 34 to Rudder
Updated by Jonathan CLARKE over 10 years ago
Dennis Cabooter wrote:
Rule compliance shows red when it should be yellow. A red compliance on a rule imply that something bad is going on. However, when I look at it, the worst status is repaired. I'm aware that if a file is repaired every run, most times something is wrong. I say most times, because in the motd technique I update last policy update data/time every run, so the file should be repaired every run and that's ok. If there is something wrong when something is repaired every run, for example if 2 directives edit the same file, people should get a warning in compliance details. Still red implies at least one error, while there isn't. I would propose to use the color of the worst status for rule compliances.
I agree with this logic.
Updated by François ARMAND over 10 years ago
- Category set to Web - Compliance & node report
- Assignee changed from François ARMAND to Vincent MEMBRÉ
Assigning to Vincent, who is the most involved in that part.
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.6.12 to 2.6.13
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.6.13 to 2.6.14
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.6.14 to 2.6.16
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.6.16 to 2.6.17
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.6.17 to 2.6.18
Updated by François ARMAND about 10 years ago
- Assignee deleted (
Vincent MEMBRÉ) - Priority changed from 2 to N/A
- Target version changed from 2.6.18 to 140
That ticket can't really be addressed until we change the way we calculate and display compliance. This will be (and is already largelly done) in http://www.rudder-project.org/redmine/issues/5297.
In that evolution, we are displaying compliance as an horizontale bar with colored zone corresponding to the percentage of elements for each state (success, repaired, error, etc). That allows to have a quick understanding of "how much" a directive is reaired.
With that highlights, I propose to close that bug and only keep #5297.
Updated by Dennis Cabooter about 10 years ago
Yeah i already saw screenshots of the modernish bars. I like it a lot. Keep up the good work. :)
Updated by Matthieu CERDA about 10 years ago
- Target version changed from 140 to 3.0.0~beta1
Updated by Jonathan CLARKE almost 10 years ago
- Status changed from 8 to Rejected
This has been addressed by #5297. I'm closing this report because it has now been fixed - don't pay attention to the "Rejected" state, this is just because there is no code attached, so I can't include it as a change :)
Thank you very much for this report Dennis, and keep them coming. I hope you like the new display :)