Project

General

Profile

Actions

Question #4611

closed

copyGitFile technique: no purge ?

Added by Olivier Mauras over 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
3
Assignee:
-
Category:
Techniques
Target version:
Regression:

Description

I find weird for purge=false in the copyGitFile technique - https://github.com/Normation/rudder-techniques/blob/master/techniques/fileDistribution/copyGitFile/1.6/copyFileFromSharedFolder.st#L106
Particularly when you sync directories, it's pretty much mandatory to me to not let old files locally - old config removed from shared-files and the likes.


Related issues 1 (0 open1 closed)

Is duplicate of Rudder - User story #5754: Add an option to allow purge of local directory content in "Copy file from shared folder" TechniqueReleased2014-11-07Actions
Actions #1

Updated by Jonathan CLARKE over 8 years ago

  • Status changed from New to Discussion
  • Target version set to 2.6.12

I agree that this should purge old files when running a recursive copy. If no one objects, let's change this behaviour.

Actions #2

Updated by Vincent MEMBRÉ over 8 years ago

What about having an option to choose if we want to purge or not old files ?

But i'm ok with changing the actual behavior to purge old files.

Actions #3

Updated by Olivier Mauras over 8 years ago

I wouldn't mind an option, but purging should be the default behaviour :)

Actions #4

Updated by Vincent MEMBRÉ over 8 years ago

  • Target version changed from 2.6.12 to 2.6.13
Actions #5

Updated by Vincent MEMBRÉ about 8 years ago

  • Target version changed from 2.6.13 to 2.6.14
Actions #6

Updated by Jonathan CLARKE about 8 years ago

  • Target version changed from 2.6.14 to 2.6.16
Actions #7

Updated by Jonathan CLARKE about 8 years ago

  • Target version changed from 2.6.16 to 2.6.17
Actions #8

Updated by Nicolas PERRON about 8 years ago

  • Target version changed from 2.6.17 to 2.6.18
Actions #9

Updated by Matthieu CERDA almost 8 years ago

  • Target version changed from 2.6.18 to 2.6.19
Actions #10

Updated by Olivier Mauras almost 8 years ago

It's been implemented in #5754 so let's just close this one don't you think ?

Actions #11

Updated by Vincent MEMBRÉ over 7 years ago

  • Target version changed from 2.6.19 to 2.6.20
Actions #12

Updated by François ARMAND over 7 years ago

  • Status changed from Discussion to Resolved

Olivier Mauras wrote:

It's been implemented in #5754 so let's just close this one don't you think ?

Yes, thanks!

(the pr is reviewed, sorry for the delay)

Actions

Also available in: Atom PDF