Project

General

Profile

Actions
Copy link

Bug #4641

closed

User story #3679: Make the agent run schedule configurable from 5 minutes to 6 hours, with configurable offset and splay time

Agent schedule is not defined as configured

Added by Jonathan CLARKE over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
1 (highest)
Assignee:
Vincent MEMBRÉ
Category:
Web - Maintenance
Target version:
2.10.0~beta1
Pull Request:
https://github.com/Normation/rudder/p...
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

I just tested the new feature from #3679, and the agent schedule is not what I expected:

I configured as follows:

And the agent schedule in generated promise files was:

        splaytime => "1";
        schedule         => { "Min00", "Min01", "Min02", "Min03", "Min04", "Min05", "Min06", "Min07", "Min08", "Min09", "Min10", "Min11", "Min12", "Min13", "Min14", "Min15", "Min16", "Min17", "Min18", "Min19", "Min20", "Min21", "Min22", "Min23", "Min24", "Min25", "Min26", "Min27", "Min28", "Min29", "Min30", "Min31", "Min32", "Min33", "Min34", "Min35", "Min36", "Min37", "Min38", "Min39", "Min40", "Min41", "Min42", "Min43", "Min44", "Min45", "Min46", "Min47", "Min48", "Min49", "Min50", "Min51", "Min52", "Min53", "Min54", "Min55", "Min56", "Min57", "Min58", "Min59" };

So, in short: splaytime is correct, but the schedule is "every minute", when I was expecting "Min02", "Min17", "Min32", "Min47".

However, the "run_interval" file contains the correct duration (15).

Note: this may be related to #4640.

Files

1.png (14.4 KB) 1.png Jonathan CLARKE, 2014-03-18 09:25
Actions
Copy link
 #1

Updated by Jonathan CLARKE over 10 years ago

I figured out why this happens. From rudder-core/src/main/scala/com/normation/rudder/services/policies/SystemVariableService.scala:

schedule <- ComputeSchedule.computeSchedule(agentRunStartHour, agentRunStartMinute, agentRunSplaytime) ?~! "Could not compute the run schedule"

The function computeSchedule is called with the wrong parameter, according to it's signature:

  def computeSchedule(                                                                                                                                                                               
      startHour        : Int
    , startMinute      : Int
    , executionInterval: Int
  ): Box[String] = {

The last parameter should be the executionInterval, not the splayTime.

Actions
Copy link
 #2

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from 8 to Pending technical review
  • Assignee changed from Nicolas CHARLES to Vincent MEMBRÉ
  • Pull Request set to https://github.com/Normation/rudder/pull/480
Actions
Copy link
 #3

Updated by Nicolas CHARLES over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Vincent MEMBRÉ over 10 years ago

  • Parent task set to #3679
Actions
Copy link
 #6

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.0~beta1, which was released today.
Check out:

The release announcement: http://www.rudder-project.org/pipermail/rudder-announce/2014-March/000084.html
    The full ChangeLog: http://www.rudder-project.org/foswiki/bin/view/System/Documentation:ChangeLog210
    Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Actions
Copy link

Also available in: Atom PDF