Project

General

Profile

Bug #4749

Add skipidentify cofniguration on Android devices

Added by Cédric Cabessa almost 6 years ago. Updated over 5 years ago.

Status:
Released
Priority:
N/A
Category:
System techniques
Target version:
Pull Request:
Severity:
User visibility:
Effort required:
Priority:

Description

In 2.10 we can manage the skipidentify option from the webapp (which is awesome)

However there is still code related to skipidentify and android:
https://github.com/Normation/rudder-techniques/blob/branches/rudder/2.10/initial-promises/node-server/failsafe.cf#L36
https://github.com/Normation/rudder-techniques/blob/branches/rudder/2.10/techniques/system/common/1.0/failsafe.st#L39

Mobile should not be treated differently (we can have unix devices without dns, and why not mobile device with dns)

The PR try to manage every device the same way.

Please review, I must say that I am not confident in my understanding of failsafe.{cf,st} vs promises.{cf,st}

Associated revisions

Revision 535807f8 (diff)
Added by Cédric Cabessa almost 6 years ago

Fix #4749: skipidentify and mobile devices

do not treat mobile devices differently.

Revision 46f3252f
Added by Nicolas CHARLES almost 6 years ago

Merge pull request #343 from CedricCabessa/skipidentify

Fix #4749: skipidentify and mobile devices

History

#2

Updated by Cédric Cabessa almost 6 years ago

  • Status changed from New to Pending release
  • % Done changed from 0 to 100

Applied in changeset commit:535807f8f42b6a232bae70df1eb003a769ad0485.

#3

Updated by Nicolas CHARLES almost 6 years ago

Applied in changeset commit:46f3252f9b6d8808ca6a5531ed469e5625d241f1.

#4

Updated by Nicolas CHARLES almost 6 years ago

  • Project changed from Techniques to Rudder
  • Category set to System techniques
  • Assignee set to Nicolas CHARLES
  • % Done changed from 100 to 0

This is perfect, thank you Cedric.

#5

Updated by Vincent MEMBRÉ over 5 years ago

  • Subject changed from skipidentify and mobile devices to Add skipidentify cofniguration on Android devices
#6

Updated by Vincent MEMBRÉ over 5 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.10.1, which was released today.
Check out:

Also available in: Atom PDF