Bug #4768
closedcheck-rudder-agent should take splaytime into account when checking the last input update file
Description
Following #4766, check-rudder-agent now takes into account the frequency of agent execution.
We decided to double the run interval so we could handle the splay time correctly and that we are sure that we haven't miss any execution.
But this case only occurs if the splaytime is very close to the frequency, otherwise the check is made really late and could have been done before:
if the frequency is every 2 hours, and the splaytime 5 minutes, if the agent has ran a 0:00, next agent run can occurs between 2:00 and 2:05 If the lock happens here, it will only be detected at ~ 4:00, so have to wait at least 1h55 before fixing the issue.
The check should look every "run Interval + splaytime + 5 minutes" (to ensure that the agent has finished to run), so you have to wait only 5 minutes after splytime to fix tcdb issues.
To do that we need a file where the splaytime is stored, like the run interval.
Updated by Nicolas CHARLES over 10 years ago
The splay is constant for a given host, it's calculation is based on the FQ Host, IP address, and user id
If you schedule is every 2 hours, with a splay of 5 minutes, you will get (for instance), execution time of 0:04:36, 2:04:36, 4:04:36, etc
So you don't feed the splaytime to the script
The whole idea of having a doubled interval was to accept that one run could be very long, and the next one missed due to that. It may indeed not make a lot of sense when interval is long.
Updated by Nicolas CHARLES over 10 years ago
I guess here the real question is : when do we consider that a run is missed ? an interval + xx minutes ? an interval * a value ? something else ?
Updated by Nicolas CHARLES over 10 years ago
- Status changed from New to Discussion
- Assignee set to Jonathan CLARKE
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.10.1 to 2.10.2
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.10.2 to 2.10.3
Updated by Jonathan CLARKE over 10 years ago
- Target version changed from 2.10.3 to 2.10.4
Updated by Nicolas PERRON over 10 years ago
- Target version changed from 2.10.4 to 2.10.5
Updated by Vincent MEMBRÉ over 10 years ago
- Target version changed from 2.10.5 to 2.10.6
Updated by Matthieu CERDA about 10 years ago
- Target version changed from 2.10.6 to 2.10.7
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.10.7 to 2.10.8
Updated by Vincent MEMBRÉ about 10 years ago
- Target version changed from 2.10.8 to 2.10.9
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.9 to 2.10.10
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.10 to 2.10.11
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.11 to 2.10.12
Updated by Vincent MEMBRÉ almost 10 years ago
- Target version changed from 2.10.12 to 2.10.13
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.13 to 2.10.14
Updated by Benoît PECCATTE over 9 years ago
- Status changed from Discussion to New
- Assignee deleted (
Jonathan CLARKE)
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.14 to 2.10.15
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.15 to 2.10.16
Updated by Vincent MEMBRÉ over 9 years ago
- Target version changed from 2.10.16 to 2.10.17
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.17 to 2.10.18
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.18 to 2.10.19
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.19 to 2.10.20
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 2.10.20 to 277
Updated by Vincent MEMBRÉ about 9 years ago
- Target version changed from 277 to 2.11.18
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.11.18 to 2.11.19
Updated by Vincent MEMBRÉ almost 9 years ago
- Target version changed from 2.11.19 to 2.11.20
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.20 to 2.11.21
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.21 to 2.11.22
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.22 to 2.11.23
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.23 to 2.11.24
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 2.11.24 to 308
Updated by Vincent MEMBRÉ over 8 years ago
- Target version changed from 308 to 3.1.14
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.14 to 3.1.15
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.15 to 3.1.16
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.16 to 3.1.17
Updated by Vincent MEMBRÉ about 8 years ago
- Target version changed from 3.1.17 to 3.1.18
Updated by Vincent MEMBRÉ almost 8 years ago
- Target version changed from 3.1.18 to 3.1.19
Updated by François ARMAND over 7 years ago
- Severity set to Minor - inconvenience | misleading | easy workaround
- User visibility set to Infrequent - complex configurations | third party integrations
- Priority set to 0
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.19 to 3.1.20
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.20 to 3.1.21
Updated by François ARMAND over 7 years ago
- User visibility changed from Infrequent - complex configurations | third party integrations to Operational - other Techniques | Technique editor | Rudder settings
- Priority changed from 0 to 14
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.21 to 3.1.22
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.22 to 3.1.23
Updated by Vincent MEMBRÉ over 7 years ago
- Target version changed from 3.1.23 to 3.1.24
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 3.1.24 to 3.1.25
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 3.1.25 to 387
Updated by Vincent MEMBRÉ about 7 years ago
- Target version changed from 387 to 4.1.10
Updated by Vincent MEMBRÉ almost 7 years ago
- Target version changed from 4.1.10 to 4.1.11
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.11 to 4.1.12
- Priority changed from 29 to 30
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.12 to 4.1.13
Updated by Vincent MEMBRÉ over 6 years ago
- Target version changed from 4.1.13 to 4.1.14
Updated by Benoît PECCATTE over 6 years ago
- Target version changed from 4.1.14 to 4.1.15
- Priority changed from 30 to 31
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.15 to 4.1.16
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.16 to 4.1.17
Updated by Vincent MEMBRÉ about 6 years ago
- Target version changed from 4.1.17 to 4.1.18
- Priority changed from 31 to 0
Updated by Vincent MEMBRÉ almost 6 years ago
- Target version changed from 4.1.18 to 4.1.19
Updated by Alexis Mousset almost 6 years ago
- Target version changed from 4.1.19 to 4.1.20
Updated by Nicolas CHARLES almost 6 years ago
- Related to Bug #14258: Cron job checking rudder agent health, is ran every 5 minutes exactly, causing resource usage spike added
Updated by Alexis Mousset over 5 years ago
- Target version changed from 4.1.20 to 588
Updated by Nicolas CHARLES over 5 years ago
- Status changed from New to Rejected
rejecting, we don't need to take splaytime into account
Updated by Alexis Mousset about 5 years ago
- Target version changed from 588 to 4.1.24