Architecture #4815
closed
Architecture #4753: Extract compliance calculus from RuleEditForm
Split logic from RuleEditForm in separate files
Description
RuleEditForm is huge, and not maintainable.
First thing I see that this file is composed of three things:
- the Edit form
- The compliance display
- The node compliance popup
I suggest to divide into three files (RuleEditForm, RuleCompliance, RuleCompliancePopup) so We don't have to manage a huge file anymore
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from New to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/508
Updated by François ARMAND over 10 years ago
- Status changed from Pending technical review to In progress
- Assignee changed from François ARMAND to Vincent MEMBRÉ
There is some remark to address in the pull request.
Updated by Jonathan CLARKE over 10 years ago
- Pull Request changed from https://github.com/Normation/rudder/pull/508 to https://github.com/Normation/rudder/pull/520
The PR was retargeted but this ticket was not updated: https://github.com/Normation/rudder/pull/520
/me takes a gold star away from Vincent ;)
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from In progress to Pending release
- % Done changed from 0 to 100
Applied in changeset ce74635e72036ff5239a06a745a4a7309b170bdd.
Updated by François ARMAND over 10 years ago
Applied in changeset 0ac159c1090dad3189943e524123b003584964f4.
Updated by Vincent MEMBRÉ over 10 years ago
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.11.0~beta1 that was released yesterday.
- announcement
- changelog
- Download information: https://www.rudder-project.org/site/get-rudder/downloads/
Updated by Benoît PECCATTE over 9 years ago
- Tracker changed from Enhancement to Architecture