Project

General

Profile

Actions

Architecture #4815

closed

Architecture #4753: Extract compliance calculus from RuleEditForm

Split logic from RuleEditForm in separate files

Added by Vincent MEMBRÉ about 10 years ago. Updated about 9 years ago.

Status:
Released
Priority:
1
Category:
Architecture - Code maintenance
Target version:
Effort required:
Name check:
Fix check:
Regression:

Description

RuleEditForm is huge, and not maintainable.

First thing I see that this file is composed of three things:

- the Edit form
- The compliance display
- The node compliance popup

I suggest to divide into three files (RuleEditForm, RuleCompliance, RuleCompliancePopup) so We don't have to manage a huge file anymore

Actions #1

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/508
Actions #2

Updated by François ARMAND about 10 years ago

  • Status changed from Pending technical review to In progress
  • Assignee changed from François ARMAND to Vincent MEMBRÉ

There is some remark to address in the pull request.

Actions #3

Updated by Jonathan CLARKE about 10 years ago

  • Pull Request changed from https://github.com/Normation/rudder/pull/508 to https://github.com/Normation/rudder/pull/520

The PR was retargeted but this ticket was not updated: https://github.com/Normation/rudder/pull/520

/me takes a gold star away from Vincent ;)

Actions #4

Updated by Vincent MEMBRÉ about 10 years ago

  • Status changed from In progress to Pending release
  • % Done changed from 0 to 100
Actions #6

Updated by Vincent MEMBRÉ almost 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.11.0~beta1 that was released yesterday.

Actions #7

Updated by Benoît PECCATTE about 9 years ago

  • Tracker changed from Enhancement to Architecture
Actions

Also available in: Atom PDF