Architecture #4815
closed
Architecture #4753: Extract compliance calculus from RuleEditForm
Split logic from RuleEditForm in separate files
Added by Vincent MEMBRÉ over 10 years ago.
Updated over 9 years ago.
Category:
Architecture - Code maintenance
Description
RuleEditForm is huge, and not maintainable.
First thing I see that this file is composed of three things:
- the Edit form
- The compliance display
- The node compliance popup
I suggest to divide into three files (RuleEditForm, RuleCompliance, RuleCompliancePopup) so We don't have to manage a huge file anymore
- Status changed from New to Pending technical review
- Assignee changed from Vincent MEMBRÉ to François ARMAND
- Pull Request set to https://github.com/Normation/rudder/pull/508
- Status changed from Pending technical review to In progress
- Assignee changed from François ARMAND to Vincent MEMBRÉ
There is some remark to address in the pull request.
- Pull Request changed from https://github.com/Normation/rudder/pull/508 to https://github.com/Normation/rudder/pull/520
- Status changed from In progress to Pending release
- % Done changed from 0 to 100
- Status changed from Pending release to Released
This bug has been fixed in Rudder 2.11.0~beta1 that was released yesterday.
- Tracker changed from Enhancement to Architecture
Also available in: Atom
PDF