Bug #4828
closed
Updating Techniques with error says on the Web Interface that everything is fine, even if it's not
Description
Creating a Technique with an obvious error (a multivalued Section which is a component without componentKey) fails, but when importing it on rudder, it silently fails
Discovered in rudder 2.10, but may exist before
Updated by Benoît PECCATTE over 9 years ago
- Category changed from 14 to Web - Config management
Updated by François ARMAND over 7 years ago
- Severity set to Minor - inconvenience | misleading | easy workaround
- User visibility set to Operational - other Techniques | Technique editor | Rudder settings
- Priority set to 0
To be more precise: there are logs in "/var/log/webapp/rudder/date.sterrout" telling us that the technique was not imported because of the error, but there is no message in the web app UI telling so.
The reason for that is that the "reload technique library" call (by the button in UI or by the api call) is asynchrone, and it only answer "I got it, I'm going to reload, kbye thx". So correcting that problem implies that we need to change that behavior to make it synchrone, or to add a "message bus" where we can publish async messages.
Updated by François ARMAND over 7 years ago
- Related to Bug #5685: Raise errors if there's issues with a technique created with ncf-builder added
Updated by François ARMAND over 7 years ago
- Effort required set to Small
- Priority changed from 14 to 31
Updated by François ARMAND over 7 years ago
- Effort required changed from Small to Very Small
- Priority changed from 31 to 42
As of 4.1, I don't see any reason to not set the technique library reload as synchrone. It would helps for:
- people developping techniques (or using the technique editor) DO WANT to know that the technique is broken,
- when you update your technique library, you do want right now that something broke
On the other hand, if nobody is editing techniques, there is no reason to reload the technique library, and so it is no grave to loose <10s if it happens, in the case where it is something surprising.
Updated by François ARMAND almost 3 years ago
- Status changed from New to Resolved
- Priority changed from 54 to 0
The discribed behavior does not match what happens in rudder 7.0:
- if the error is in the technique editor, we do have UI notification,
- if the error is from a manual (git base) import, we do have error messages in logs.
- more generally, we enhanced the reporting on these cases rudder version after rudder version.
Moreover, the proposed change of making reload sync is a non trivial architecture change, already tried unsuccessfully.
I'm closing that ticket, and if a precise case of missing info appears, we will open a new ticket: I'm closing this one.