Project

General

Profile

Actions

Bug #4932

closed

cf-agent slowed by users addition into inventory and displays a lot of warnings about that

Added by Nicolas CHARLES almost 10 years ago. Updated almost 10 years ago.

Status:
Released
Priority:
4
Category:
System techniques
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When we run the agent (version 2.9 or more), the inventory generation is riddled with

> 2014-06-03T10:26:15+0000     info: insert_lines promise uses the same select_line_matching anchor '.*<USERSLIST>.*' as another promise. This will lead to non-convergent behaviour unless 'empty_file_before_editing' is set
> 2014-06-03T10:26:15+0000     info: Promise belongs to bundle 'add_users_information_to_inventory' in file '/var/rudder/cfengine-community/inputs/inventory/1.0/fusionAgent.cf' near line 516
> 2014-06-03T10:26:15+0000     info: Comment is 'Add the UUID and CFKEY tags in the inventory file'

which is quite scary.
The cause is that we do the insert of user list in the inventory by iterating over the user list, rather than passing the list to the bundle edit_line and do one iteration.
Changing the $ by a @ saves 50KB of Inform output for the inventory generation.

Actions

Also available in: Atom PDF