Project

General

Profile

Actions

Bug #4947

closed

If we select a Rule category (other than top) then reload the Rule page, the state of the Rule table is not coherent.

Added by Vincent MEMBRÉ over 10 years ago. Updated over 10 years ago.

Status:
Released
Priority:
1 (highest)
Category:
Web - Config management
Target version:
Severity:
UX impact:
User visibility:
Effort required:
Priority:
Name check:
Fix check:
Regression:

Description

When we select a Rule sub-category, we filter the rule table to only display rules on that category.
Then if we reload the page, the displayed selected category in the tree is the top one (Rules), but the list of rules only displays rules from the previously selected sub-category.

And so, we have a really bad inconsistency (the user may think that some rules disapeared).

The problem is that the state of the table is saved in a cookie, and so the filter is still aplied on the table when reloading the page.
But the selected category in the tree is not saved, and so the default one is kept.
So we can either also save the category to highlight in the tree, or reset the filter in the table. The second solution is much more simple, so we are going to that one as bug correction, and we will consider keeping all the state in as a new feature.

Actions #1

Updated by Vincent MEMBRÉ over 10 years ago

Two solutions here:

- We reset the filter when loading the page, so it looks like the root category was selected

- We managed to extract the information on the selected Rule category, and set the selected category to the one savec in the filter.

First one seems easier to do, and will be done in that issue.

The second one may be done in a future release if we want that behavior.

Actions #2

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from New to Pending technical review
  • Assignee changed from Vincent MEMBRÉ to François ARMAND
  • Pull Request set to https://github.com/Normation/rudder/pull/537
Actions #3

Updated by François ARMAND over 10 years ago

  • Subject changed from If we select a Rule category then reload the Rule page, the state of the Rule table is not coherent. to If we select a Rule category (other than top) then reload the Rule page, the state of the Rule table is not coherent.
  • Description updated (diff)
Actions #4

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending technical review to Pending release
  • % Done changed from 0 to 100
Actions #6

Updated by Vincent MEMBRÉ over 10 years ago

  • Status changed from Pending release to Released

This bug has been fixed in Rudder 2.9.5 (announcement , changelog) and 2.10.1 (announcement , changelog), which were released today.

Actions

Also available in: Atom PDF