Bug #5030: Invalid promises generated for distributePolicy as of #5025 - Rudder - Issue Tracker

Actions

Bug #5030

closed

User story #4928: Allow splitting Rudder into independent role-based entities

User story #5025: Update the rudder-rsyslog configuration and send inventory target to send syslog message and inventory to the proper component

Invalid promises generated for distributePolicy as of #5025

Added by Jonathan CLARKE over 10 years ago. Updated over 10 years ago.

Status:

Released

Priority:

1 (highest)

Assignee:

Nicolas CHARLES

Category:

System techniques

Target version:

2.11.0~beta1

Pull Request:

https://github.com/Normation/rudder-t...

Severity:

UX impact:

User visibility:

Effort required:

Priority:

Name check:

Fix check:

Regression:

Description

I get this:

⇨ cf-promise check fails for promises generated at '/var/rudder/cfengine-community/inputs.new'
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:73:18: error: syntax error
⇨ ifvarclass => "!role_rudder_db_server_defined";
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:73:18: error: Check previous line, Expected ',', got 'ifvarclass'
⇨ ifvarclass => "!role_rudder_db_server_defined";
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:73:21: error: Expected promiser string, got '=>'
⇨ ifvarclass => "!role_rudder_db_server_defined";
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:73:54: error: Expected ';', got '"!role_rudder_db_server_defined"'
⇨ ifvarclass => "!role_rudder_db_server_defined";
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:73:55: error: Expected promiser string, got ';'
⇨ ifvarclass => "!role_rudder_db_server_defined";
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:74:30: error: Expected ';', got '"rudder_postgres_server"'
⇨ "rudder_postgres_server" string => "${rudder_servers_by_role.roles[rudder-db]}" 
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:74:37: error: Expected promiser string, got 'string'
⇨ "rudder_postgres_server" string => "${rudder_servers_by_role.roles[rudder-db]}" 
⇨ ^
⇨ /var/rudder/cfengine-community/inputs.new/distributePolicy/1.0/rsyslogConf.cf:74:40: error: Expected ';', got '=>'
⇨ "rudder_postgres_server" string => "${rudder_servers_by_role.roles[rudder-db]}" 
⇨ ^
⇨ 2014-06-15T19:08:32+0200 error: There are syntax errors in policy files

It is due to 2 missing commas on these promises.

Actions

Copy link

Updated by Jonathan CLARKE over 10 years ago

Status changed from In progress to Pending technical review
Assignee changed from Jonathan CLARKE to Nicolas CHARLES
Pull Request set to https://github.com/Normation/rudder-techniques/pull/414